From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 77898 invoked by alias); 7 Mar 2019 17:11:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 77884 invoked by uid 89); 7 Mar 2019 17:11:23 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=Marchi, marchi, HContent-Transfer-Encoding:8bit X-HELO: mail-wr1-f49.google.com Received: from mail-wr1-f49.google.com (HELO mail-wr1-f49.google.com) (209.85.221.49) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Mar 2019 17:11:22 +0000 Received: by mail-wr1-f49.google.com with SMTP id f14so18330627wrg.1 for ; Thu, 07 Mar 2019 09:11:22 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id s5sm5358981wra.77.2019.03.07.09.11.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 Mar 2019 09:11:20 -0800 (PST) Subject: Re: MinGW build failure for GDB 8.2.90 with source-highlight To: Simon Marchi , Eli Zaretskii References: <83r2bibvlv.fsf@gnu.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <10c9e85f-d216-ef5c-c8ca-636331d0d1ba@redhat.com> Date: Thu, 07 Mar 2019 17:11:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-03/txt/msg00158.txt.bz2 On 03/07/2019 04:59 PM, Simon Marchi wrote: > I don't recall what's the long term solution for this.  We could use gnulib's namespace support [2], but the disadvantage is that we would need to use gnulib::some_function (assuming we name the namespace "gnulib") instead of just some_function to use the "fixed" version.  If we use some_function directly, it will use the buggy version on those systems where it is buggy. Wrap all of gdb in a namespace. Recall that this was what led to C++ wildmatching support. Thanks, Pedro Alves