From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68285 invoked by alias); 13 Jan 2019 05:09:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68246 invoked by uid 89); 13 Jan 2019 05:09:44 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,GIT_PATCH_1,KAM_SHORT,KAM_TK,MIME_BASE64_BLANKS,SPF_PASS autolearn=ham version=3.3.2 spammy=Finally, weren't, UD:tk, werent X-HELO: sesbmg23.ericsson.net Received: from sesbmg23.ericsson.net (HELO sesbmg23.ericsson.net) (193.180.251.37) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Jan 2019 05:09:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1547356176; x=1549948176; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Wbw1lgXmP/m2M6tR/X353RI6g0cPB00w23Xhb0orcMo=; b=KbwTtRLUPK2B3E9+/D9kTk4JnbVHrFpRQw0sTO79gsXBGo4THVQPTrz30V82/Xlk Pw+48zO8oYGaLIQNsvXGpM38nYEmkU1BSj4pjcronqXqv2+V2/mCWcp2b5fgRwxs 0Qx3mEed8unf9EPvLrfTCOr/eyUFHOhHbhcW7ygLz8c=; Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 6E.54.24567.018CA3C5; Sun, 13 Jan 2019 06:09:36 +0100 (CET) Received: from ESESBMB504.ericsson.se (153.88.183.171) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Sun, 13 Jan 2019 06:09:34 +0100 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (153.88.183.157) by ESESBMB504.ericsson.se (153.88.183.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3 via Frontend Transport; Sun, 13 Jan 2019 06:09:33 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wbw1lgXmP/m2M6tR/X353RI6g0cPB00w23Xhb0orcMo=; b=EiiFsdWLmt+VC8Cri+ZZUPWuOWA0akc8U+qX4DbFBEbVpDUaxglcsn9no1N172nGcBnNd2DSS9JLcBA0iER8hZ18kMZy1+tPNH5J5IWdPThdYLHRK4DEbnXSFYqklP9pSLTOEBCaTi74CekLQUz5UvykGse5avT9ZQYKqzzIB4g= Received: from BYAPR15MB2390.namprd15.prod.outlook.com (52.135.198.30) by BYAPR15MB3381.namprd15.prod.outlook.com (20.179.59.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1516.13; Sun, 13 Jan 2019 05:09:29 +0000 Received: from BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e]) by BYAPR15MB2390.namprd15.prod.outlook.com ([fe80::a4b4:ea6a:6321:191e%4]) with mapi id 15.20.1516.019; Sun, 13 Jan 2019 05:09:29 +0000 From: Simon Marchi To: Eli Zaretskii CC: "gdb-patches@sourceware.org" , "palves@redhat.com" Subject: Re: [PATCH] Fix MI output for multi-location breakpoints Date: Sun, 13 Jan 2019 05:09:00 -0000 Message-ID: <10a03370-3f18-a716-eaca-5da6621d1660@ericsson.com> References: <20190111001516.4761-1-simon.marchi@ericsson.com> <83lg3rhb6r.fsf@gnu.org> <7cf31d37-3931-bbac-07f2-c61f57be142c@ericsson.com> <83y37qgail.fsf@gnu.org> In-Reply-To: <83y37qgail.fsf@gnu.org> authentication-results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Content-Type: text/plain; charset="utf-8" Content-ID: <1E4D1733C700AF4186CF010E81F33DE6@namprd15.prod.outlook.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Return-Path: simon.marchi@ericsson.com X-IsSubscribed: yes X-SW-Source: 2019-01/txt/msg00305.txt.bz2 Pj4+PiAtQHNhbXB7LS1pbnRlcnByZXRlcj1taX0gKG9yIEBzYW1wey0taW50 ZXJwcmV0ZXI9bWkyfSkgY2F1c2VzDQo+Pj4+ICtAc2FtcHstLWludGVycHJl dGVyPW1pfSAob3IgQHNhbXB7LS1pbnRlcnByZXRlcj1taTN9KSBjYXVzZXMN Cj4+Pj4gIEB2YWx1ZXtHREJOfSB0byB1c2UgdGhlIEBkZm57QHNje2dkYi9t aX0gaW50ZXJmYWNlfSAoQHB4cmVme0dEQi9NSSwgLA0KPj4+PiAtVGhlIEBz Y3tnZGIvbWl9IEludGVyZmFjZX0pIGluY2x1ZGVkIHNpbmNlIEB2YWx1ZXtH REJOfSB2ZXJzaW9uIDYuMC4gIFRoZQ0KPj4+PiAtcHJldmlvdXMgQHNje2dk Yi9taX0gaW50ZXJmYWNlLCBpbmNsdWRlZCBpbiBAdmFsdWV7R0RCTn0gdmVy c2lvbiA1LjMgYW5kDQo+Pj4+IC1zZWxlY3RlZCB3aXRoIEBzYW1wey0taW50 ZXJwcmV0ZXI9bWkxfSwgaXMgZGVwcmVjYXRlZC4gIEVhcmxpZXINCj4+Pj4g LUBzY3tnZGIvbWl9IGludGVyZmFjZXMgYXJlIG5vIGxvbmdlciBzdXBwb3J0 ZWQuDQo+Pj4+ICtUaGUgQHNje2dkYi9taX0gSW50ZXJmYWNlfSkuICBUaGUg QHNje2dkYi9taX0gaW50ZXJmYWNlcyAxIGFuZCAyIGFyZQ0KPj4+PiArYXZh aWxhYmxlLCBidXQgZGVwcmVjYXRlZC4gIEVhcmxpZXIgQHNje2dkYi9taX0g aW50ZXJmYWNlcyBhcmUgbm8NCj4+Pj4gK2xvbmdlciBhdmFpbGFibGUuDQo+ Pj4NCj4+PiBQbGVhc2UgZG9uJ3QgcmVtb3ZlIHRoZSB2ZXJzaW9uIGluZm9y bWF0aW9uIGZyb20gdGhpcyB0ZXh0LiAgQXQgdGhlDQo+Pj4gdmVyeSBsZWFz dCwgd2Ugc2hvdWxkIHRlbGwgd2hhdCBHREIgdmVyc2lvbiBpbnRyb2R1Y2Vk IHRoZSBsYXRlc3QgbWkzDQo+Pj4gc3ludGF4LiAgV2Ugc2hvdWxkIHRlbGwg dGhpcyBoZXJlLCBhbmQgbm90IG9ubHkgaW4gdGhlICJJbnRlcnByZXRlcnMi DQo+Pj4gbm9kZSwgYmVjYXVzZSB0aGlzIHNlY3Rpb24gaXMgYSBjb25jaXNl IGxpc3Qgb2YgaW52b2NhdGlvbiBvcHRpb25zLA0KPj4+IGFuZCBzaG91bGQg aW5jbHVkZSB0aGUgaW1wb3J0YW50IGluZm9ybWF0aW9uIHdpdGhvdXQgc2Vu ZGluZyB0aGUNCj4+PiByZWFkZXIgdG8gcmVhZCB0aGUgbW9yZSBkZXRhaWxl ZCBwYXJ0cy4NCj4+DQo+PiBUaGUgcmVhc29uIEkgdGhvdWdodCB0aGlzIHdh cyBub3QgcmVhbGx5IGFwcHJvcHJpYXRlIGhlcmUgaXMgdGhhdCB0aGlzIG1h bnVhbA0KPj4gYXBwbGllcyB0byBhIHBhcnRpY3VsYXIgdmVyc2lvbiBvZiBH REIgKGUuZy4gaXQncyB0aGUgbWFudWFsIHNoaXBwZWQgd2l0aA0KPj4gR0RC IDkuMSkuICBTbyBpZiB5b3UgYXJlIHVzaW5nIHRoYXQgdmVyc2lvbiBvZiBH REIsIGl0IGRvZXNuJ3QgcmVhbGx5IG1hdHRlcg0KPj4gd2hpY2ggdmVyc2lv biBvZiBHREIgaW50cm9kdWNlZCBtaTMsIGFsbCB0aGF0IG1hdHRlcnMgaXMg dGhhdCBpdCBleGlzdHMgbm93Lg0KPiANCj4gUGVvcGxlIHJlYWQgbmV3ZXIg bWFudWFscyBldmVuIGlmIHRoZXkgaGF2ZSBvbGRlciB2ZXJzaW9ucyBvZiBH REINCj4gYXZhaWxhYmxlLiAgRS5nLiwgSSBoYXZlIG9uIG15IGRldmVsb3Bt ZW50IHN5c3RlbSBhbGwgdGhlIHZlcnNpb25zIG9mDQo+IEdEQiBzaW5jZSB2 Ni4zLCBidXQgb25seSBvbmUgdmVyc2lvbiBvZiB0aGUgbWFudWFsLCB0aGUg bGF0ZXN0IG9uZS4NCj4gU2luY2UgVGV4aW5mbyBkb2Vzbid0IHByb3ZpZGUg YSB3YXkgb2YgaW5zdGFsbGluZyBzZXZlcmFsIHZlcnNpb25zIG9mDQo+IHRo ZSBzYW1lIG1hbnVhbCBzaWRlIGJ5IHNpZGUsIHdlIHNob3VsZCBhc3N1bWUg dGhhdCBteSBzaXR1YXRpb24gaXMNCj4gcXVpdGUgdHlwaWNhbC4NCj4gDQo+ IFNvIGxldCdzIG5vdCBhc3N1bWUgdGhhdCB3aGVuIG9uZSByZWFkcyBhIG1h bnVhbCBmb3IgR0RCIFguWSB0aGV5IGFyZQ0KPiBpbnRlcmVzdGVkIG9ubHkg aW4gdGhhdCBHREIgdmVyc2lvbi4NCg0KQnV0IHdlIGNvdWxkIHNheSB0aGF0 IGZvciBldmVyeSBzaW5nbGUgZmVhdHVyZS4gIFdlIGludHJvZHVjZWQgKG9y IHJhdGhlciwgd2lsbA0KaW50cm9kdWNlKSAic2V0IGluZGV4LWNhY2hlIiBp biBHREIgOC4zLCBhbmQgd2UgZG9uJ3QgbWVudGlvbiBpbiB0aGUgZG9jIHRo YXQgaXQNCmV4aXN0cyBzaW5jZSA4LjMuDQoNCj4+IEFzIHlvdSBzYWlkLCB0 aGlzIHNlY3Rpb24gaXMgYSBjb25jaXNlIGxpc3Qgb2YgaW52b2NhdGlvbiBv cHRpb25zLiAgQnV0IEkgZG9uJ3QNCj4+IGNvbnNpZGVyIHRoaXMgdmVyeSBp bXBvcnRhbnQgaW5mb3JtYXRpb24gdG8gaGF2ZSBhdCB0aGUgZmluZ2VydGlw cy4NCj4gDQo+IEkgcmVzcGVjdGZ1bGx5IGRpc2FncmVlLiAgQSBtYW51YWwg aXMgbW9yZSBvZnRlbiB0aGFuIG5vdCByZWFkIGFzIGENCj4gcmVmZXJlbmNl LCB3aGVyZSB0aGUgcmVhZGVyIHdhbnRzIHRvIHF1aWNrbHkgZmluZCB0aGUg aW5mb3JtYXRpb24gdGhleQ0KPiBhcmUgYWZ0ZXIsIGFuZCBzdG9wIHJlYWRp bmcgcmlnaHQgYWZ0ZXIgdGhhdC4gIFdlIHNob3VsZCBjYXRlciB0byBzdWNo DQo+IHVzYWdlIG9mIHRoZSBtYW51YWwsIHNpbmNlIGl0J3MgSU1FIHRoZSBt b3N0IGltcG9ydGFudCB1c2UuDQoNCkkgYWdyZWUgdGhhdCB0aGUgZ2VuZXJh bCB1c2UgY2FzZSBvZiB0aGUgbWFudWFsIGlzIG5vdCB0byByZWFkIGl0IGZy b20gY292ZXIgdG8gY292ZXIuDQoNCj4+IEFzIEFuZHJldyBzdWdnZXN0ZWQs IEkgdGhpbmsgd2Ugc2hvdWxkIGhhdmUgYSBsaXN0IG9yIHRhYmxlIG9mIGFs bCBtaSB2ZXJzaW9ucywNCj4+IHdoZW4gdGhleSB3ZXJlIGludHJvZHVjZWQs IGFuZCB3aGF0IHRoZSBicmVha2luZyBjaGFuZ2VzIGFyZS4gIFRoaXMgd291 bGQgaGVscA0KPj4gcGVvcGxlIHdyaXRpbmcgb3IgdXBncmFkaW5nIHRoZWly IE1JIGZyb250ZW5kLiAgIEJ1dCBJIGRvbid0IHRoaW5rIHRoYXQgdGhlDQo+ PiBjYXN1YWwgdXNlciBsb29raW5nIGZvciB0aGUgcG9zc2libGUgY29tbWFu ZCBsaW5lIGZsYWdzIHdpbGwgbmVlZCB0byBrbm93IHRoZQ0KPj4gaGlzdG9y eSBvZiBNSS4NCj4gDQo+IEknbSBva2F5IHdpdGggYWRkaW5nIGEgZGV0YWls ZWQgdGFibGUgZWxzZXdoZXJlLCBidXQgSSBkb24ndCB0aGluaw0KPiBpdCdz IGEgZ29vZCBpZGVhIHRvIHJlbW92ZSB0aGUgYWJvdmUgaW5mb3JtYXRpb24g ZnJvbSB0aGUgZGVzY3JpcHRpb24NCj4gb2YgdGhlIC1taSBjb21tYW5kLWxp bmUgc3dpdGNoLg0KDQpXb3VsZCBhIGNyb3NzLXJlZmVyZW5jZSB0byB0aGUg dGFibGUgYmUgZ29vZCBlbm91Z2g/ICBJZiB3ZSBhZGQgYSBkZXRhaWxlZCB0 YWJsZQ0Kb2YgTUkgdmVyc2lvbnMgKHdoaWNoIEkgdGhpbmsgaXMgcmVxdWly ZWQpLCB3ZSB3aWxsIGhhdmUgdGhlIGluZm9ybWF0aW9uIGFib3V0IHdoaWNo DQpHREIgdmVyc2lvbiBpbnRyb2R1Y2VkIGVhY2ggTUkgdmVyc2lvbnMgYXQg dGhyZWUgc2VwYXJhdGUgcGxhY2VzIGluIHRoZSBtYW51YWwuLi4NCkkgdGhp bmsgdGhpcyBqdXN0IGFkZHMgdW5uZWNlc3Nhcnkgb3ZlcmhlYWQgZm9yIHdo ZW4gd2Ugd2FudCB0byBhZGQgYSBuZXcgTUkgdmVyc2lvbg0KKEkga25vdyB0 aGlzIGRvZXNuJ3QgaGFwcGVuIG9mdGVuLCBidXQgc3RpbGwpLg0KDQpBY3R1 YWxseSwgdGhlcmUgaXMgYWxyZWFkeSBhIGNyb3NzIHJlZmVyZW5jZSBqdXN0 IGFib3ZlLiAgSSB3b3VsZCBjb25zaWRlciByZXdvcmRpbmcNCnRoaW5ncyBh IGJpdCB0byBiZSBjbGVhciB0aGF0ICJ0byBrbm93IG1vcmUgYWJvdXQgdGhl IGF2YWlsYWJsZSBpbnRlcnByZXRlcnMsIHNlZQ0KQ29tbWFuZCBJbnRlcnBy ZXRlcnMiLg0KDQo+PiBGaW5hbGx5LCB0aGUgZ29hbCBpcyB0byByZWR1Y2Ug dGhlIGR1cGxpY2F0aW9uIG9mIGluZm9ybWF0aW9uLCBzbyB0aGVyZSBpcyBs ZXNzDQo+PiB0aGluZ3MgdG8gdXBkYXRlIHdoZW4gcmVsZWFzaW5nIGEgbmV3 IE1JIHZlcnNpb24gKHRoZXJlZm9yZSBsZXNzIGNoYW5jZSBvZiBoYXZpbmcN Cj4+IG91dGRhdGVkIGluZm9ybWF0aW9uKS4NCj4gDQo+IFRoYXQgaXMgbm90 IHRoZSBtYWluIGdvYWwsIHRob3VnaC4gIFRoZSBtYWluIGdvYWwgaXMgdG8g cHJvZHVjZSBhDQo+IHVzZWZ1bCBtYW51YWwgdGhhdCBhbGxvd3MgZmluZGlu ZyB0aGUgaW5mb3JtYXRpb24gb25lIG5lZWRzIHF1aWNrbHkNCj4gYW5kIGVm ZmljaWVudGx5Lg0KDQpSaWdodCwgSSBtZWFudCAibXkgZ29hbCIsIG5vdCB0 aGUgZ29hbCBvZiB0aGUgR0RCIG1hbnVhbC4gIEkgYmVsaWV2ZSBhIGNyb3Nz LXJlZmVyZW5jZQ0Kd291bGQgYWxsb3cgcGVvcGxlIGZpbmQgdGhhdCBpbmZv cm1hdGlvbiBxdWlja2x5IGFuZCBlZmZpY2llbnRseS4NCg0KPj4+PiAgQGl0 ZW0gbWkxDQo+Pj4+ICBAY2luZGV4IG1pMSBpbnRlcnByZXRlcg0KPj4+PiAt VGhlIEBzY3tnZGIvbWl9IGludGVyZmFjZSBpbmNsdWRlZCBpbiBAdmFsdWV7 R0RCTn0gNS4xLCA1LjIsIGFuZCA1LjMuDQo+Pj4+ICtUaGUgQHNje2dkYi9t aX0gaW50ZXJmYWNlIGludHJvZHVjZWQgaW4gQHZhbHVle0dEQk59IDUuMS4N Cj4+Pg0KPj4+IEkgdGhpbmsgdGhlIG9sZCB0ZXh0IGlzIGJldHRlci4NCj4+ DQo+PiBUaGUgcHJvYmxlbSBJIHNlZSB3aXRoIHRoZSBjdXJyZW50IHdvcmRp bmcgaXMgdGhhdCBpdCBpbXBsaWVzIHRoYXQgbWkxIGlzIGluY2x1ZGVkDQo+ PiBpbiB2ZXJzaW9uIDUuMSwgNS4yIGFuZCA1LjMgb25seS4NCj4gDQo+IFRo YXQncyBub3QgbXkgaW50ZXJwcmV0YXRpb24gb2YgImluY2x1ZGVkIGluIi4N Cj4+PiBJbiByZWFsaXR5LCBpdCdzIGluY2x1ZGVkIGluIGFsbCB2ZXJzaW9u cyBmcm9tIDUuMSBhbmQgdXAuICBTbyBpdA0KPj4gc2VlbXMgb2RkIHRvIGxp c3QgNS4yIGFuZCA1LjMgc3BlY2lmaWNhbGx5LiAgRG8geW91IGhhdmUgYQ0K Pj4gc3VnZ2VzdGlvbiB0byBhZGRyZXNzIHRoaXM/DQo+IA0KPiBTYXkgInVz ZWQgYnkiIGluc3RlYWQgb2YgImluY2x1ZGVkIGluIj8NCg0KT2ssIHNvIHRo ZXJlIGFyZSB0d28gdGhpbmdzIGJvdGhlcmluZyBtZSBpbiB0aGUgY3VycmVu dCB0ZXh0LCBhbmQgSSBhbSBub3Qgc3VyZSBpZg0Kd2UgYXJlIGluIGRpc2Fn cmVlbWVudCB3aXRoIGJvdGggb3IganVzdCBvbmUuDQoNCi0gbWkxIGNhbiBi ZSB1c2VkIGJ5IGFueSBHREIgdmVyc2lvbiBiZXR3ZWVuIDUuMSBhbmQgdGhl IHByZXNlbnQuICBXaHkgZG8gd2UgbGlzdA0KICBzcGVjaWZpY2FsbHkgNS4x LCA1LjIgYW5kIDUuMz8gIEl0J3Mgbm90IHVudHJ1ZSB0byBzYXkgdGhhdCBt aTEgaXMgYXZhaWxhYmxlIGluDQogIDUuMSwgNS4yIGFuZCA1LjMsIGJ1dCBp dCdzIGFtYmlndW91cyB3aGV0aGVyIHRoaXMgaXMgYW4gZXhoYXVzdGl2ZSBs aXN0IG9yIG5vdC4NCiAgQmV0dGVyIGp1c3Qgc2F5IGl0J3MgNS4xIGFuZCB1 cC4NCi0gVGhlIHRlcm0gImluY2x1ZGVkIGluIiwgb3IgInVzZWQgYnkiLCBy ZWdhcmRsZXNzIG9mIHdoZXRoZXIgaXQgaXMgY291cGxlZCB3aXRoICI1LjEi DQogIG9yIDUuMSwgNS4yIGFuZCA1LjMiLiAgU2luY2UgbWkxIGNhbiBiZSB1 c2VkIHdpdGggYW55IHZlcnNpb24gYmV0d2VlbiA1LjEgYW5kIHRoZQ0KICBs YXRlc3QgcmVsZWFzZSwgSSB0aGluayB3ZSBzaG91bGQgYmUgbG9va2luZyBm b3IgYSBwaHJhc2luZyB0aGF0IGNvbnZleXMgdGhhdCBpdCdzDQogIGFuIGhh bGYtb3BlbiBpbnRlcnZhbC4gIFNheWluZyB0aGF0ICJtaTEgaXMgdXNlZCBi eSBHREIgNS4xIiBqdXN0IHRlbGxzIHlvdSBhYm91dA0KICA1LjEuICBTYXlp bmcgdGhhdCAibWkxIGlzIGF2YWlsYWJsZSBzdGFydGluZyB3aXRoIEdEQiA1 LjEiIHRlbGxzIHlvdSBhYm91dCBhbGwNCiAgdmVyc2lvbnMgYmV0d2VlbiA1 LjEgYW5kIHRoZSBjdXJyZW50IG9uZS4NCg0KSG9wZWZ1bGx5IHRoYXQgY2xl YXJzIHVwIHdoeSBJIHNlZSB0aGUgbmVlZCB0byByZS13b3JkIHRoaXMuDQoN Cg0KPj4+IFAuUy4gSSB3b25kZXIgaG93IGRpZCB3ZSBsZXQgdGhpcyBwcm9i bGVtIHNsaXAgdGhyb3VnaCB0aGUgY3JhY2tzIHdoZW4NCj4+PiBtdWx0aXBs ZS1sb2NhdGlvbiBicmVha3BvaW50cyB3ZXJlIGludHJvZHVjZWQ/ICBNYXli ZSB3ZSBzaG91bGQgZG8NCj4+PiBzb21ldGhpbmcgdG8gYXZvaWQgc3VjaCBt aXN0YWtlcyBpbiB0aGUgZnV0dXJlLiAgV2UgcmVhbGx5IHNob3VsZG4ndA0K Pj4+IGJlIGNoYW5naW5nIHRoZSBNSSBzeW50YXggaW4gaW5jb21wYXRpYmxl IHdheXMgc28gbGF0ZSBpbnRvIEdEQg0KPj4+IGRldmVsb3BtZW50IGN5Y2xl Lg0KPj4NCj4+IFdlbGwgaXQncyBiZWVuIGtub3duIGZvciBhIGxvbmcgdGlt ZSwgYXMgc2hvd3MgdGhpcyBidWcgZnJvbSAyMDA4IChBRkFJVSwNCj4+IG11 bHRpcGxlIGxvY2F0aW9uIGJyZWFrcG9pbnRzIHdlcmUgaW50cm9kdWNlZCBh cm91bmQgMjAwNz8pOg0KPj4NCj4+IGh0dHBzOi8vc291cmNld2FyZS5vcmcv YnVnemlsbGEvc2hvd19idWcuY2dpP2lkPTk2NTkNCj4+DQo+PiBJJ3ZlIGJl ZW4gbWVhbmluZyB0byBmaXggdGhpcyBmb3IgYSBmZXcgeWVhcnMsIGJ1dCBh bHdheXMgcHV0IGl0IGFzaWRlICh1bnRpbCBub3cpDQo+PiBiZWNhdXNlIG9m IHRoZSBoZWFkYWNoZSBpbnRyb2R1Y2luZyBiYWNrd2FyZHMtaW5jb21wYXRp YmxlIE1JIGNoYW5nZXMgcmVwcmVzZW50cy4NCj4gDQo+IFRoYXQncyBub3Qg d2hhdCBib3RoZXJlZCBtZS4gIFdoYXQgYm90aGVyZWQgbWUgd2FzIHRoYXQg d2UgcmVsZWFzZWQgYQ0KPiBHREIgd2l0aCB0aGlzIE1JIHN5bnRheCB3aXRo b3V0IGZpeGluZyBpdCBmaXJzdC4gIEknbSB3b25kZXJpbmcgaG93IHRvDQo+ IHByZXZlbnQgc3VjaCBtaXN0YWtlcyBpbiB0aGUgZnV0dXJlLg0KDQpUaGUg cHJvYmxlbSBoZXJlIGlzIHRoYXQgd2UgaGFkIGEgdHVwbGUgd2l0aG91dCBu YW1lL2lkIGluIGEgY29udGV4dCB3aGVyZSB0aGlzDQpzaG91bGQgYmUgZm9y YmlkZGVuLiAgTWF5YmUgd2UgY291bGQgYWRkIHNvbWUgYXNzZXJ0IGluIHVp X291dDo6YmVnaW4gdG8gY2F0Y2gNCnRoaXMuDQoNCkFsc28sIHRoZXNlIE1J IGNvbW1hbmRzIGFuZCBhc3luYyBldmVudHMgd2VyZW4ndCBwcm9wZXJseSB0 ZXN0ZWQgaW4gdGhlIHRlc3RzdWl0ZS4NCkJ1dCBldmVuIGlmIHRoZXkgd2Vy ZSwgb3VyIHRlc3RzIGFyZW4ndCBidWxsZXRwcm9vZiwgc2luY2Ugd2UgbWF0 Y2ggTUkgb3V0cHV0IHRleHR1YWxseS4NCldlIGRvbid0IGNvbmZpcm0gdGhh dCB0aGUgb3V0cHV0IGhhcyB2YWxpZCBNSSBzeW50YXguDQoNCkluc3RlYWQg b2YgbWF0Y2hpbmcgdGhlIE1JIG91dHB1dCB0ZXh0dWFsbHksIHdlIHNob3Vs ZCBoYXZlIGEgcHJvcGVyIE1JIG91dHB1dCBwYXJzZXINCndyaXR0ZW4gaW4g VENMLiAgVGhpcyB3b3VsZCBtZWFuIHRoYXQgYW55IG91dHB1dCBwcm9kdWNl ZCBieSBHREIgaW4gTUkgY291bGQgYmUgcmFuDQp0aHJvdWdoIHRoaXMgcGFy c2VyLCBhbmQgYW55IG5vbi1jb25mb3JtaW5nIG91dHB1dCB3b3VsZCBjYXVz ZSBhbiBlcnJvci4NCg0KSSBkb24ndCBrbm93IGlmIGFueWJvZHkgaXMgcmVh ZHkgdG8gd3JpdGUgc3VjaCBhIHBhcnNlci4gIEFuIGlkZWEgb3V0IHRoZXJl IHdvdWxkIGJlDQpmb3IgR0RCIHRvIHVzZSBKU09OIGZvciBNSSwgaW5zdGVh ZCBvZiBpdHMgb3duIGZvcm1hdCAod2hpY2ggaXMgY2xvc2UgdG8gSlNPTiBh bnl3YXkpLg0KVGhlbiB3ZSBjb3VsZCBwcm9iYWJseSB1c2UgYW4gZXhpc3Rp bmcgbGlicmFyeSwgc3VjaCBhcw0KDQogIGh0dHBzOi8vY29yZS50Y2wudGsv dGNsbGliL2RvYy90cnVuay9lbWJlZGRlZC93d3cvdGNsbGliL2ZpbGVzL21v ZHVsZXMvanNvbi9qc29uLmh0bWwNCg0KbWFraW5nIHRoZSBwcm9jZXNzIG11 Y2ggZWFzaWVyLg0KDQpUaGFua3MsDQoNClNpbW9uDQo= >From gdb-patches-return-153416-listarch-gdb-patches=sources.redhat.com@sourceware.org Sun Jan 13 05:18:31 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 73543 invoked by alias); 13 Jan 2019 05:18:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 73527 invoked by uid 89); 13 Jan 2019 05:18:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=effectiveness, Hx-languages-length:1722, colour X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Jan 2019 05:18:28 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 29783117872; Sun, 13 Jan 2019 00:18:27 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id yWjuPliCM4tY; Sun, 13 Jan 2019 00:18:27 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6DB2611786A; Sun, 13 Jan 2019 00:18:25 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id C479F86749; Sun, 13 Jan 2019 09:18:18 +0400 (+04) Date: Sun, 13 Jan 2019 05:18:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: Philippe Waroquiers , gdb-patches@sourceware.org Subject: Re: [RFA 1/3] Use function_name_style to print Ada and C function names Message-ID: <20190113051818.GE22922@adacore.com> References: <20190110220113.26169-1-philippe.waroquiers@skynet.be> <20190110220113.26169-2-philippe.waroquiers@skynet.be> <87bm4lx2v3.fsf@tromey.com> <1547310557.5979.5.camel@skynet.be> <87zhs5trcq.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zhs5trcq.fsf@tromey.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-SW-Source: 2019-01/txt/msg00306.txt.bz2 Content-length: 1656 > >>>>> "Philippe" == Philippe Waroquiers writes: > > Philippe> ada-typeprint.c:print_func_type is only called to print types that are > Philippe> functions. So, that effectively prints a function name. > > No opinion on that one, maybe Joel could say. I tried to think about the general context, and the guideline in my mind is that there is a fine line where coloring is helpful and when it becomes too much, reducing the effectiveness of colorization. In this case, this patch seems to advocate in favor of colorization? Perhaps we might indeed find it useful to colorize type names. But, for the sake of consistency, let's color all type names, rather than just function ones. And perhaps one thing we could do to avoid an explosion of colorization options, which themselves can lead to visual-confusion-by-color-mosaic effect, is to compromise a bit by saying type names should be styled similarly to their object counterparts. Eg: same colour, but with a "dim" filter? For instance, if addresses are in blue, then types which are pointers/refs, etc, could be printed in dim blue? One thing I might do, regardless of the decision, is define in the code a different style for this kind of entity, even if, internally, the style itself is just a reference (an "alias", if you will), of an existing style. That way, it is easier to keep track of the various kinds of entities and their style, thus allowing us the option of upgrading this kind of entities to their own style if we wanted to. Otherwise, we'd have to audit all the existing calls to styling to see which ones we want to style separately. -- Joel