From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32690 invoked by alias); 1 Nov 2004 22:05:18 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 32680 invoked from network); 1 Nov 2004 22:05:16 -0000 Received: from unknown (HELO cpc1-oxfd5-5-0-cust86.oxfd.cable.ntl.com) (80.6.110.86) by sourceware.org with SMTP; 1 Nov 2004 22:05:16 -0000 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by cpc1-oxfd5-5-0-cust86.oxfd.cable.ntl.com (8.12.11/8.12.11) with ESMTP id iA1MBb8Q031402 for ; Mon, 1 Nov 2004 22:11:37 GMT Subject: Re: [PATCH] Seg fault whilst stepping when watch set [ping!] [in breakpoint.c] From: David Lecomber To: patches In-Reply-To: <1098720391.1935.0.camel@delmo.priv.wark.uk.streamline-computing.com> References: <1097972182.22738.7.camel@localhost.localdomain> <1098720391.1935.0.camel@delmo.priv.wark.uk.streamline-computing.com> Content-Type: text/plain Message-Id: <1099347096.31287.3.camel@cpc1-oxfd5-5-0-cust86.oxfd.cable.ntl.com> Mime-Version: 1.0 Date: Mon, 01 Nov 2004 22:05:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-11/txt/msg00027.txt.bz2 Two week ping!!!! This really is an obviously harmless patch, not necessarily an obvious patch, but it's one that can only stop a segfault that would otherwise happen, so could someone give the ok please.. d. On Mon, 2004-10-25 at 17:06, David Lecomber wrote: > One week ping.. > > > Ping!! > > d. > > On Sun, 2004-10-17 at 01:16, David Lecomber wrote: > > Unfortunately I can't reproduce this without the intel compiler/f90. > > However, the relevant GDB output was: > > (gdb) r > > Starting program: /home/david/f90demo > > [Thread debugging using libthread_db enabled] > > [New Thread -151084928 (LWP 24298)] > > [Switching to Thread -151084928 (LWP 24298)] > > > > Breakpoint 1, 0x08089e8a in main () > > (gdb) step > > Single stepping until exit from function main, > > which has no line number information. > > > > sample () at f90demo.f90:72 > > 72 CALL MPI_INIT(ierr) > > Current language: auto; currently fortran > > (gdb) watch i > > Hardware watchpoint 2: i > > (gdb) step > > Error in re-setting breakpoint 2: > > No symbol "i" in current context. > > > > > > This being line when breakpoint.c:949 calls evaluate_expression where > > exp is 0. > > > > I propose the attached, which has fixed this seg fault on my system. > > Permission to commit? > > > > 2004-10-17 > > > > * breakpoint.c (insert_bp_location): Regenerate expression in > > breakpoint owner for watchpoints if null. > > > >