Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Toshihito Kikuchi <k.toshihito@yahoo.de>
To: "Paul_Koning@Dell.com" <Paul_Koning@Dell.com>,
		"palves@redhat.com" <palves@redhat.com>
Cc: "jhb@freebsd.org" <jhb@freebsd.org>,
		"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Add a new format letter to dump instructions backward
Date: Tue, 26 Jan 2016 05:39:00 -0000	[thread overview]
Message-ID: <1095889805.138513.1453786618993.JavaMail.yahoo@mail.yahoo.com> (raw)
In-Reply-To: <F83BD80E-E1AA-4C1E-86BB-9A995B831256@dell.com>

Thank you for the great suggestion.

I also agree that #3, adding the support for a negative number, looks reasonable. I'll get back to this thread when the code is ready.

To answer the question from Paul, Pedro's guess is correct. I used symbol's line info to solve a correct frame. And yes, this feature does not work without debug information unfortunately. Since I'm not familiar with architectures other than x86, let me finish this work in the current approach first. If there are architectures where instruction length is fixed, I think I can add them later.


> Adding some tests would be great.  Also, the documentation
> will need to be updated.
> 
> If you haven't yet, please take a look at:
> https://sourceware.org/gdb/wiki/ContributionChecklist
Thank you for pointing to this. I looked at only gdb/CONTRIBUTE and didn't reach this. Tests and doc updates will be included in next patch.


Thanks,
Toshihito


  reply	other threads:[~2016-01-26  5:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1827952218.466587.1453670934999.JavaMail.yahoo.ref@mail.yahoo.com>
2016-01-24 21:31 ` Toshihito Kikuchi
2016-01-25 11:41   ` Pedro Alves
2016-01-25 18:10     ` John Baldwin
2016-01-25 18:22       ` Paul_Koning
2016-01-25 18:27         ` Pedro Alves
2016-01-25 20:11           ` Paul_Koning
2016-01-26  5:39             ` Toshihito Kikuchi [this message]
2016-01-27 16:04               ` Andrew Burgess
2016-01-27 20:09                 ` Paul_Koning
2016-01-28 11:53                   ` Pedro Alves
2016-02-07 23:19                     ` [PATCH] Negative repeat count for 'x' command Toshihito Kikuchi
2016-02-17 11:38                       ` Pedro Alves
2016-03-23  0:27                         ` Toshihito Kikuchi
2016-04-11 12:17                       ` Pedro Alves
2016-04-15  0:30                         ` Toshihito Kikuchi
     [not found]                           ` <5714DE73.5010104@redhat.com>
2016-04-28 18:06                             ` Toshihito Kikuchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1095889805.138513.1453786618993.JavaMail.yahoo@mail.yahoo.com \
    --to=k.toshihito@yahoo.de \
    --cc=Paul_Koning@Dell.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jhb@freebsd.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox