From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8162 invoked by alias); 20 Aug 2004 13:45:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8155 invoked from network); 20 Aug 2004 13:45:53 -0000 Received: from unknown (HELO cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com) (81.105.116.12) by sourceware.org with SMTP; 20 Aug 2004 13:45:53 -0000 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com (8.12.11/8.12.11) with ESMTP id i7KE20nT027497; Fri, 20 Aug 2004 15:02:01 +0100 Subject: Re: [PATCH/RFA] PR gdb/648 (eval.c approval reqd) From: David Lecomber To: Jim Blandy Cc: patches In-Reply-To: <1093009988.5529.40.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> References: <1091830216.4188.23.camel@localhost> <1092659964.5816.5.camel@localhost> <1093009988.5529.40.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> Content-Type: text/plain Message-Id: <1093010520.5529.44.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> Mime-Version: 1.0 Date: Fri, 20 Aug 2004 13:45:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00593.txt.bz2 Oops, missed out a line on the ChangeLog -- * dwarf2read.c (read_array_order): New function. (read_array_type): Use read_array_order to check row/column major ordering. > Fix PR gdb/648 > * language.h (enum array_ordering): New enum. > * language.h (struct language_defn): New la_array_ordering > attribute. > * language.c (unknown_language_defn, auto_language_defn) > (local_language_defn): Ditto. > * ada-lang.c (ada_language_defn): Ditto. > * c-lang.c (c_language_defn, cplus_language_defn) > (asm_language_defn, minimal_language_defn): Ditto. > * f-lang.c (f_language_defn): Ditto. > * jv-lang.c (java_language_defn): Ditto. > * m2-lang.c (f_language_defn): Ditto. > * objc-lang.c (objc_language_defn): Ditto. > * p-lang.c (pascal_language_defn): Ditto. > * scm-lang.c (scm_language_defn): Ditto. > * eval.c (evaluate_subexp_standard): Assume Fortran arrays are > oriented large to small in type structure. > > > > On Wed, 2004-08-18 at 17:32, Jim Blandy wrote: > > Thanks for the revisions! > > > > Any reason read_array_ordering can't return 'enum > > dwarf_array_dim_ordering' instead of 'int'? > > > > The special case for GNU F77 needs a comment --- just explaining that > > F77 does things backwards as of Aug 2004, etc. etc. Basically what > > you said in your original post, explaining why the special case was > > necessary. > > > > With those changes, the dwarf2read.c portions of this change are > > approved. So I think the eval.c stuff is all that's left for someone > > to review.