I've made the enum change, and added comments -- the revised patches are attached. Anyone eval.c maintainer ready to approve these changes? Cheers David 2004-08-16 David Lecomber Fix PR gdb/648 * language.h (enum array_ordering): New enum. * language.h (struct language_defn): New la_array_ordering attribute. * language.c (unknown_language_defn, auto_language_defn) (local_language_defn): Ditto. * ada-lang.c (ada_language_defn): Ditto. * c-lang.c (c_language_defn, cplus_language_defn) (asm_language_defn, minimal_language_defn): Ditto. * f-lang.c (f_language_defn): Ditto. * jv-lang.c (java_language_defn): Ditto. * m2-lang.c (f_language_defn): Ditto. * objc-lang.c (objc_language_defn): Ditto. * p-lang.c (pascal_language_defn): Ditto. * scm-lang.c (scm_language_defn): Ditto. * eval.c (evaluate_subexp_standard): Assume Fortran arrays are oriented large to small in type structure. On Wed, 2004-08-18 at 17:32, Jim Blandy wrote: > Thanks for the revisions! > > Any reason read_array_ordering can't return 'enum > dwarf_array_dim_ordering' instead of 'int'? > > The special case for GNU F77 needs a comment --- just explaining that > F77 does things backwards as of Aug 2004, etc. etc. Basically what > you said in your original post, explaining why the special case was > necessary. > > With those changes, the dwarf2read.c portions of this change are > approved. So I think the eval.c stuff is all that's left for someone > to review.