From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5984 invoked by alias); 16 Aug 2004 12:33:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5964 invoked from network); 16 Aug 2004 12:33:05 -0000 Received: from unknown (HELO black-watch.firstnet.net.uk) (212.103.224.244) by sourceware.org with SMTP; 16 Aug 2004 12:33:05 -0000 Received: (qmail 24577 invoked from network); 16 Aug 2004 12:34:13 -0000 Received: from unknown (HELO localhost.localdomain) (212.103.239.121) by black-watch.first with SMTP; 16 Aug 2004 12:34:13 -0000 Received: from localhost (castle.priv.wark.uk.streamline-computing.com [192.168.1.249]) by localhost.localdomain (8.12.8/8.12.8) with ESMTP id i7GCWHXY004360; Mon, 16 Aug 2004 13:32:34 +0100 Subject: Re: [PATCH/RFA] PR gdb/648 From: David Lecomber To: Jim Blandy Cc: patches In-Reply-To: References: <1091830216.4188.23.camel@localhost> Content-Type: text/plain Message-Id: <1092659613.5816.0.camel@localhost> Mime-Version: 1.0 Date: Mon, 16 Aug 2004 12:33:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-08/txt/msg00535.txt.bz2 On Fri, 2004-08-13 at 23:10, Jim Blandy wrote: > David Lecomber writes: > > 2004-08-06 David Lecomber > > > > Fix PR gdb/648 > > * dwarf2read.c (read_array_type): Handle column major arrays > > correctly. Assume column major for Fortran except with G77 > > compiler. > > * eval.c (evaluate_subexp_standard): Assume Fortran arrays are > > oriented large to small in type structure. > > Thanks very much for the patch and test program. It was helpful to be > able to actually look at what GNU F77 was producing for a real Fortran > program. > > For the dwarf2read.c part, I think the essential approach is fine. > However: > > - Rather than recognizing Fortran specially in read_array_type, I'd > rather have a new member of 'struct language_defn' giving the array > ordering for that language. > > - I'd like to have the logic that chooses a byte order pulled out of > read_array_type into its own function that takes a die, a cu, and > returns a DW_ORD_ value. That function would take care of looking > for a DW_AT_ordering attribute, recognizing the appropriate versions > of GNU F77, and so on. read_array_type should call that function > and build the type appropriately.