From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22410 invoked by alias); 21 Jul 2004 07:12:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22355 invoked from network); 21 Jul 2004 07:12:43 -0000 Received: from unknown (HELO cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com) (81.105.116.12) by sourceware.org with SMTP; 21 Jul 2004 07:12:43 -0000 Received: from [127.0.0.1] (localhost.localdomain [127.0.0.1]) by cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com (8.12.11/8.12.11) with ESMTP id i6L7S57C032404; Wed, 21 Jul 2004 08:28:05 +0100 Subject: Re: Dwarf2 Producer info From: David Lecomber To: Daniel Jacobowitz Cc: patches In-Reply-To: <20040721000823.GA10146@nevyn.them.org> References: <1090362598.21483.108.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> <20040720231756.GA8250@nevyn.them.org> <1090367767.21483.120.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> <20040721000823.GA10146@nevyn.them.org> Content-Type: text/plain Message-Id: <1090394885.21483.134.camel@cpc4-oxfd5-5-0-cust12.oxfd.cable.ntl.com> Mime-Version: 1.0 Date: Wed, 21 Jul 2004 07:12:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-07/txt/msg00276.txt.bz2 Fine by me -- in fact, even the null setting isn't needed now I've found the bit that ensures the cu is cleared during allocation (do you agree?). So here goes: 2004-07-20 David Lecomber * dwarf2read.c (read_file_scope): Set producer if attribute present. Index: dwarf2read.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2read.c,v retrieving revision 1.156 diff -p -r1.156 dwarf2read.c *** dwarf2read.c 6 Jul 2004 19:29:30 -0000 1.156 --- dwarf2read.c 21 Jul 2004 07:07:03 -0000 *************** struct dwarf2_cu *** 262,267 **** --- 262,269 ---- enum language language; const struct language_defn *language_defn; + const char* producer; + /* The generic symbol table building routines have separate lists for file scope symbols and all all other scopes (local scopes). So we need to select the right one to pass to add_symbol_to_list(). *************** read_file_scope (struct die_info *die, s *** 2362,2367 **** --- 2364,2373 ---- set_cu_language (DW_UNSND (attr), cu); } + attr = dwarf2_attr (die, DW_AT_producer, cu); + if (attr) + cu->producer = DW_STRING (attr); + /* We assume that we're processing GCC output. */ processing_gcc_compilation = 2; #if 0 On Wed, 2004-07-21 at 01:08, Daniel Jacobowitz wrote: > On Wed, Jul 21, 2004 at 12:56:07AM +0100, David Lecomber wrote: > > > > > Is set_cu_producer going to do anything else? Otherwise I don't see > > > the point of the wrapper function. > > > > Hi Dan, > > > > Not in the immediately foreseeable future, but I can imagine a situation > > where the producer is matched with some known producer strings and an > > enumerated constant is stored instead; if that ever happens, it will be > > better if there's one setter. > > There will still be only one setter; let's drop the useless wrapper, > unless one of the dwarf2 maintainers feels otherwise.