From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gZPbKeDIc2mzwREAWB0awg (envelope-from ) for ; Fri, 23 Jan 2026 14:15:44 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=N9R3I44u; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A86021E0AD; Fri, 23 Jan 2026 14:15:44 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 300D71E089 for ; Fri, 23 Jan 2026 14:15:44 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id BA3234C31802 for ; Fri, 23 Jan 2026 19:15:43 +0000 (GMT) Received: from sonic308-18.consmr.mail.ir2.yahoo.com (sonic308-18.consmr.mail.ir2.yahoo.com [77.238.178.146]) by sourceware.org (Postfix) with ESMTPS id 6B66F4BC89B1 for ; Fri, 23 Jan 2026 19:12:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6B66F4BC89B1 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=yahoo.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=yahoo.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6B66F4BC89B1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=77.238.178.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769195579; cv=none; b=so8iurEfaQOBbSHMVlTU/jPp6wfixWGOVnVdXqhtuKKzHwFVLxdCalCmwCeaM3rn+Y4TnaJS6M28b6PXMh0+gDTWAN3qLcHJB0keIZfxRHoHdZa6Bv5I+6wTwpXfG9PaU+NKnyKX2GX1xu3aw1NXoVkheUIxzSgch2+icKC4d8U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769195579; c=relaxed/simple; bh=Y1zZ+2bN3y5xlT6ooWPoP8d4aUz8XGnY5eQTD9pvM30=; h=DKIM-Signature:Date:From:To:Message-ID:Subject:MIME-Version; b=Jlv+RJi23wCHqlhYJDZSkBjjJbTqIdRNQ21V+5K7NyYUEysxA55zwFw0dhXp6n5oq/hQWuakUJyZ78aBZlMvEBZ9oORWGA8kxEmcwEFfhrT7pSAM/FX4F9/aQJ6CFXu4VKqydfNh6vpdlNtHFnNYW1ABTrfGF+IFB1Dd7OZOa5E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6B66F4BC89B1 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=yahoo.de header.i=@yahoo.de header.a=rsa-sha256 header.s=s2048 header.b=N9R3I44u DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.de; s=s2048; t=1769195562; bh=Y1zZ+2bN3y5xlT6ooWPoP8d4aUz8XGnY5eQTD9pvM30=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From:Subject:Reply-To; b=N9R3I44uTliBjGN8ARhezstcd3BL3HRxvYsPmbEP2r4HAQdt/CPioC8fn3GA18mLQTnLc0GK5QwH1/3xz5AdOze5tZx0Fdr6lzti/nFvsaP6qRg1oSCWw/3l7PlvhlkWEPoe97GtPO72z+uNBW5qmuKBW6o6XT99fE6AydGcRbwGUy+M45gt8llldg0Lg/IHcAhYL5hPIloaYSNehvefu0T4uYFeCOcefbKQ5IiXatcy0ifU3HpdfrqUpMVJLfBW0JKwnJEpLO9fUJ4Vfv4n+DJz0A9LwPJjwy3rv7uepj4a8SLUsMMtS7v1M3t2PqfMJSgX0ijKvP4vDuVpRcQfoA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1769195562; bh=uUVoZBg/2xZpWeLcu/VVJ3pqdDuB4Kc7CWPPAMZ09sb=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=XS/JOTkc/zA8oP7oz7eghTibLBWVwewpurD5TJUNEgsyDsQG4ikDHYR2oTMFDc0e6isTF0+VtPqW7Qq20S7S/R0In3vtwGSzu7IV7RODxrqcOeqvwYQ4i9Z2LNbxTKbIbW13xmpbA8D38ZQa4c+vWU/NR70O6psZGvZ8hjMrNBJjHv+rmnAkA5t4J3qJ++LToMkInEpekviwat0NKDbNaTkPZjRydCMBk8lPgrjroyOHrOg/VWH9A8rJQtOek0RG3Xy68I4/NMJ9b7PpfnB/xo76xS3UWAfEc66GOuDfQ1HRAlkCYPhdJBaBT+dA9SOxXcbwP2zFnOtOwLDgkwww+w== X-YMail-OSG: eWxOlqMVM1mqo1o5l0sCTRrZUkj9_9oo5xtr1TJidvgdVU.4Kb_zsLa4ohhAf0F b37CGO2HPB.AVgArxI2W1tiI_YLTful0iUQskaBHE85CmkKO1yLlLFECc6QMjN7L.Rh3SePK0iO1 Wku9YIrSst5f8lXcXoEfa1.HIkrRtvDPwpiD5.Xa0Xa2mOuxXls9mMW9Dk5ZGlXqVySUjbA4AkB4 4UyNVbeHNKrlgRl4WxWyQZ_6hUuxpay30P0ZRR9vFcUDmO158FWnl4RDCsOrHvuN03jL_pxtyV3z iKvtwN4Ko3dJElqaD_xIrxJuISv6JpKh9YarHzZh39KGr2_W8QDULbmS9WNn0c.yYpzh4kQTGTkL qyBgRsVfEUXhJp8Y364MhFRSjS0xT84eMWjg48i9H4qYB9VG4SHJ0lGxHJqPRfzmnerP2Zai7x1Z V8wUSD6WXSoZpFxzov8065psEEFC0XcFL_FFIvrk9.LpB.Nif54qu0dYKzCe7bil11w4dJyNslLu lldnUpYQk7f1QqTItF1Q2DCbVsUUm53GlZlmNjL0bBrZsyKK0mLHOu20xQiBV6TVXc1oNngd4lq6 kSmkJCjxeF4aDyV_VD7Wi49HgIpRkrmZfOLFUGqNnFxUEITjNcrGK4TBo9n9tOef8QapbVwIZlLM r2I5K1It45WmGHHRFWlwQ8fKBIUi750JzXijMGCTsCr5bVMpkHjeVTCbYgfiGqQKe83l5DYom65L wC8C5jUH2x2NYvtqurc2Zyaz.Dqp94W6J6t8X.agHaMujIPETX59.6Zl71CTRdTjTdeimJCw5p_Q soGmYoTwODdvPxqXPN0ueL6HFBeRKxUyw_sbzelVdTcE90zYKE5RrmzlroUG16pSdzmdFfx6iCJQ tJAdJzSJbOHK94DcTA2uCpcJ9WgLhVdfSFlIche6IteLKoBAUw3Mr1jmghGfOShAxSTtW_L9diva twZvtFJ6A89ZK7Lgy9LpwuvAZFXiaXUbcr6rhR3LID2a7EJ5CGRk_m93WMiE2aa_Wg5eP0O84bBh uwM2JUaJgHYZ6jWZ7spv2EMEIVFFNWXRjoq3yOU2oHpqOUjkMI9uiiDXKpgtPZGQ_YukIt34r0Re MRpUlSfGvERcKgsPWlXx2hAPD8yafyjrIyzsIqMAvOOQTwbEf4ku_X71aobVHNr2Bs1DpULEVkuU tCZYfbGgwAcyvPpF2iqZteV1U78VfAkM3uhkIZeCqwvRFoegy7s_GsSWBU7LRzgIgvdHW0Ft0Sok _ltzuGfYIszM5LB0rOKF8QKuGVhuPyRRHwJru1OprmtC10Ro26xBB5x8QdEX1_eex5kJzXXEqRGn nr0DU_6RMZs50K4CBo21.33tdspBdl5v6LXPWgEgp06_88LQ5wsY43kG02r0gXd0VpyuzfNzbkpN 5uHKkQ1LTk5m_Rd9CWlMLK4lCc39XFfu2.kU5WhD3aN4PxvXPj1TbgSQLoohILGqip9VKrGHs7gh DFZZpVwBI.W9I9SH6OZUDsY2Mm5IKqwfdbpqqd8iMvAnoizW4jziKvRY5_kxfR2uAxKCtiezlKt8 34Pt_UdrT0bq0T_JKJlI9dFFVwU8ZNWrQhw_W1bmVs_wI7mLA.Bn.NDFp0gY_j8iRQmoEmREER_M 2laOOdFnqE4_6FQhjuBrrBJFm2Ks7e79uUEmyxtIoZZwDPI.nKVe10tn0CcIoLcjdtQWrhLZuJu3 cE4WQ2xXg7PAxkxfZw0jue7WEouRGW7JTEyxuMS0dTM9UFITbMAK1zWhDO3pgYVYX2tbfgnTh0Cz _GFnkMfXATR2uREOpuNNEofDduDH86S88nz5Dr_obsKIVP48WpRkM9vHUblSTmSke03_1CBdb4C9 YHiUfY4XaXs_1YirizehR358i155SeJAs2L2ObYvfRboaZdyg8h_8RI4OaQ_eE7tDVonmmYVUL_S ilW5ezXvjpmiJwM5DxV2xuu9eV8qO6sC9wE.Gld4DH2Gnj1pFgoNm6MB32H1xcf_R.0M5cWu23y8 LfPY2q9mennRBBPTRL.l3WxT7sv7cyGqsPrzFqruJgN87qVAzaHs24ff96UXXb6fVIXFOD391yVY tpydPlL6lCJDXRScZ3EEZLY9RODpkEh4SrhMrHuALmB3e1bBsshD6zbNSTWUJ3z5jmJOm4OdqV8g 7s_RzELjByIGIaftddNzK2luyRNTecatmcw2VjAMkinA4oDQ7XXpvwx6_gVn7ycLH0IyRiHzfQtY fR43AArNUysngYjSWfHsO1ZO1lNHq X-Sonic-MF: X-Sonic-ID: 93ffd4b9-614d-4f5d-9e71-0cc884f7fda2 Received: from sonic.gate.mail.ne1.yahoo.com by sonic308.consmr.mail.ir2.yahoo.com with HTTP; Fri, 23 Jan 2026 19:12:42 +0000 Date: Fri, 23 Jan 2026 19:12:39 +0000 (UTC) From: Hannes Domani To: "Schimpe, Christina" , Tom Tromey Cc: "gdb-patches@sourceware.org" Message-ID: <108728853.6278001.1769195559014@mail.yahoo.com> In-Reply-To: <87sebz7yyw.fsf@tromey.com> References: <20260117134052.2660009-1-ssbssa@yahoo.de> <20260117134052.2660009-8-ssbssa@yahoo.de> <87sebz7yyw.fsf@tromey.com> Subject: Re: [PATCH v2 08/11] Move software breakpoint recognition code into x86-windows-nat.c MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.24987 YMailNorrin X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Am Mittwoch, 21. Januar 2026 um 16:43:55 MEZ hat Tom Tromey Folgendes geschrieben: > >>>>> Schimpe, Christina writes: >=C2=A0 > >> + is_sw_breakpoint (EXCEPTION_RECORD *er) =3D 0; >=C2=A0 > > Nit: Shouldn't this better be "const EXCEPTION_RECORD *er" ? >=C2=A0 > I guess if we're doing that we should consider >=C2=A0 >=C2=A0 =C2=A0 =C2=A0is_sw_breakpoint (const EXCEPTION_RECORD *er) const = =3D 0; >=C2=A0 > since presumably this method isn't mutating *this. Thanks, I've added both const. Hannes