Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Martin M. Hunt" <hunt@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] dwarf2 read_reg
Date: Tue, 08 Jun 2004 04:08:00 -0000	[thread overview]
Message-ID: <1086667710.5507.27.camel@hunt.cipe.redhat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

The read_reg() function made an assumption that sizeof pointer 
was the same as a register size.  This broke lots of things
for architectures like mips.

2004-05-26  Martin Hunt  <hunt@redhat.com>
 
        * dwarf2-frame.c (read_reg): Use register_size() instead
        of sizeof pointer.

-- 
Martin M. Hunt <hunt@redhat.com>
Red Hat Inc.

[-- Attachment #2: 040526-1-dwarf2_frame.diff --]
[-- Type: text/x-patch, Size: 653 bytes --]

Index: gdb/dwarf2-frame.c
===================================================================
RCS file: /cvs/cvsfiles/gnupro/gdb/dwarf2-frame.c,v
retrieving revision 1.4.2.1
diff -u -p -u -r1.4.2.1 dwarf2-frame.c
--- gdb/dwarf2-frame.c	20 May 2004 03:46:47 -0000	1.4.2.1
+++ gdb/dwarf2-frame.c	25 May 2004 23:29:11 -0000
@@ -214,8 +214,8 @@ read_reg (void *baton, int reg)
 
   buf = (char *) alloca (register_size (gdbarch, regnum));
   frame_unwind_register (next_frame, regnum, buf);
-  return extract_typed_address (buf, builtin_type_void_data_ptr);
+  return extract_signed_integer (buf, register_size (current_gdbarch, regnum));
 }
 
 static void

             reply	other threads:[~2004-06-08  4:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-08  4:08 Martin M. Hunt [this message]
2004-06-08  7:53 ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1086667710.5507.27.camel@hunt.cipe.redhat.com \
    --to=hunt@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox