From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-31700-listarch-gdb-patches=sources.redhat.com@sources.redhat.com>
Received: (qmail 26757 invoked by alias); 22 Mar 2004 04:30:12 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 26727 invoked from network); 22 Mar 2004 04:30:11 -0000
Received: from unknown (HELO external2.doc.com) (199.72.38.17)
  by sources.redhat.com with SMTP; 22 Mar 2004 04:30:11 -0000
Received: (qmail 2850 invoked from network); 22 Mar 2004 04:30:10 -0000
Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO ?192.168.1.101?) (24.221.209.215)
  by external2.doc.com with SMTP; 22 Mar 2004 04:30:10 -0000
Subject: Re: [RFA]: Fix objc/1236 - printing non-debuggable symbols
From: Adam Fedor <fedor@doc.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
In-Reply-To: <1077638167.19364.8.camel@localhost.localdomain>
References: <3EE150E9.2080003@doc.com>
	 <16433.23008.848603.345992@localhost.redhat.com>
	 <1077638167.19364.8.camel@localhost.localdomain>
Content-Type: text/plain
Organization: 
Message-Id: <1079929809.1190.0.camel@localhost.localdomain>
Mime-Version: 1.0
Date: Mon, 22 Mar 2004 04:30:00 -0000
Content-Transfer-Encoding: 7bit
X-SW-Source: 2004-03/txt/msg00491.txt.bz2

On Tue, 2004-02-24 at 08:56, Adam Fedor wrote:
> On Mon, 2004-02-16 at 17:01, Elena Zannoni wrote:
> > Adam Fedor writes:
> >  > Fixes PR objc/1236
> >  > 
> >  > 2003-06-06  Adam Fedor  <fedor@gnu.org>
> >  > 
> >  > 	Fix objc/1236.
> >  > 	* gdb/linespec.c (decode_line_2): Print non-debuggable (minimal)
> >  > 	symbols.
> >  > 	(decode_objc): Update for change in arguments to decode_line_2
> >  > 	(find_methods): Likewise.
> >  > 
> > 
> > 
> > sorry for the delay, this got lost in my pile.  I see what you are
> > doing, but could you have 2 separate arrays of symbol pointers and of
> > msymbol pointers instead of concatenating the two? This way you would
> > also simplify the find_imps code (no need to swap the symbols and the
> > msymbols) and also the call to decode_line_2 in the c++ code would
> > look less weird, it could just pass NULL's.
> > 
> 
> Well I looked into doing this, but splitting up the arrays looks pretty
> ugly and more error prone than the other approach. Plus the arrays have
> to be combined eventually in decode_line_2 anyway. 

Ping.