From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7572 invoked by alias); 1 May 2013 17:38:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7559 invoked by uid 89); 1 May 2013 17:38:26 -0000 X-Spam-SWARE-Status: No, score=-5.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_PASS,TW_CP autolearn=ham version=3.3.1 Received: from hop-nat-141.emc.com (HELO mexforward.lss.emc.com) (168.159.213.141) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 01 May 2013 17:38:25 +0000 Received: from hop04-l1d11-si01.isus.emc.com (HOP04-L1D11-SI01.isus.emc.com [10.254.111.54]) by mexforward.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id r41HcNlq001920 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 1 May 2013 13:38:23 -0400 Received: from mailhub.lss.emc.com (mailhubhoprd02.lss.emc.com [10.254.221.253]) by hop04-l1d11-si01.isus.emc.com (RSA Interceptor) for ; Wed, 1 May 2013 13:38:10 -0400 Received: from usendtaylorx2l.lss.emc.com (usendtaylorx2l.lss.emc.com [10.243.10.188]) by mailhub.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id r41Hc9YP013254 for ; Wed, 1 May 2013 13:38:09 -0400 Received: by usendtaylorx2l.lss.emc.com (Postfix, from userid 26043) id BCDAB5AFD20; Wed, 1 May 2013 13:38:06 -0400 (EDT) Received: from usendtaylorx2l (localhost [127.0.0.1]) by usendtaylorx2l.lss.emc.com (Postfix) with ESMTP id 9454B5AFD09 for ; Wed, 1 May 2013 13:38:06 -0400 (EDT) From: David Taylor To: gdb-patches@sourceware.org Subject: [PATCH] Fix for QTro remote packet Date: Wed, 01 May 2013 17:38:00 -0000 Message-ID: <10772.1367429886@usendtaylorx2l> X-EMM-MHVC: 1 X-SW-Source: 2013-05/txt/msg00009.txt.bz2 In function remote_trace_set_readonly_regions in gdb/remote.c, the local variable 'offset' does not account for "QTro" at the start of the packet with the result that if there are any read-only regions, the packet is sent -- but without the "QTro" -- causing the remote stub to report that the packet is unsupported. For gdb/ChangeLog: 2013-05-01 David Taylor * remote.c (remote_trace_set_readonly_regions): Do not overwrite "QTro" at start of packet. Here's a one line patch to gdb/remote.c of gdb 7.6: --- remote.c~ 2013-04-12 12:04:50.000000000 -0400 +++ remote.c 2013-05-01 12:45:10.000000000 -0400 @@ -10652,6 +10652,7 @@ return; /* No information to give. */ strcpy (target_buf, "QTro"); + offset = strlen (target_buf); for (s = exec_bfd->sections; s; s = s->next) { char tmp1[40], tmp2[40]; This is small enough that no copyright assignment should be needed, but EMC has one on file. David -- David Taylor dtaylor@emc.com