From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28413 invoked by alias); 8 Feb 2004 05:17:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 28400 invoked from network); 8 Feb 2004 05:17:26 -0000 Received: from unknown (HELO external2.doc.com) (199.72.38.17) by sources.redhat.com with SMTP; 8 Feb 2004 05:17:26 -0000 Received: (qmail 7388 invoked from network); 8 Feb 2004 05:17:25 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO ?192.168.1.101?) (24.221.209.215) by external2.doc.com with SMTP; 8 Feb 2004 05:17:25 -0000 Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc From: Adam Fedor To: Andrew Cagney Cc: Elena Zannoni , "gdb-patches@sources.redhat.com" In-Reply-To: <4023E404.2090407@gnu.org> References: <4016E401.2050001@gnu.org> <16409.26976.292424.689823@localhost.redhat.com> <1075433366.29218.7.camel@localhost.localdomain> <16417.28535.67901.37314@localhost.redhat.com> <40217AE6.9060500@gnu.org> <4023E404.2090407@gnu.org> Content-Type: text/plain Organization: Message-Id: <1076217443.1224.1.camel@localhost.localdomain> Mime-Version: 1.0 Date: Sun, 08 Feb 2004 05:17:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-02/txt/msg00172.txt.bz2 On Fri, 2004-02-06 at 11:59, Andrew Cagney wrote: > > Um, I'm not sure what is happening. My GNU/Linux amd64 box appears to pass both times: > > I've found the right machine (YelloDog 3.0), the attached appears to > work on both yellow dog and IRIX (and Fedora Core). > > The new patch modifies find_pc_partial_function supply the PC's section > when available. > > Look ok? > > The problem was that the symbol lookup was finding a symbol from a > previous section, instead of no symbol in the current section. That > leads to this test (using Joe's rewrite): > > > + if (ecs->stop_func_name == NULL > > + && step_over_calls == STEP_OVER_UNDEBUGGABLE) > > + { > > + /* We couldn't determine where we stopped, so we just stepped > > + inside undebuggable code. Since we want to step over this > > + kind of code, we keep going until the inferior returns from > > + the current function. */ > > + handle_step_into_function (ecs); > > + return; > > + } > > not triggering. ->stop_func_name had a non-NULL but bogus symbol name. > > ok? Current gdb with this patch works fine for me (using PR 1237 and PR 1280 tests).