From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12578 invoked by alias); 30 Jan 2004 04:53:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12495 invoked from network); 30 Jan 2004 04:53:25 -0000 Received: from unknown (HELO external2.doc.com) (199.72.38.17) by sources.redhat.com with SMTP; 30 Jan 2004 04:53:25 -0000 Received: (qmail 5103 invoked from network); 30 Jan 2004 04:53:23 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO ?192.168.1.101?) (24.221.209.215) by external2.doc.com with SMTP; 30 Jan 2004 04:53:23 -0000 Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc From: Adam Fedor To: "gdb-patches@sources.redhat.com" Cc: Elena Zannoni , Andrew Cagney In-Reply-To: <401994EE.9060306@gnu.org> References: <4016E401.2050001@gnu.org> <16409.26976.292424.689823@localhost.redhat.com> <401994EE.9060306@gnu.org> Content-Type: multipart/mixed; boundary="=-aDaSvL7evbCWoQ6W7H1i" Organization: Message-Id: <1075438401.29218.20.camel@localhost.localdomain> Mime-Version: 1.0 Date: Fri, 30 Jan 2004 04:53:00 -0000 X-SW-Source: 2004-01/txt/msg00757.txt.bz2 --=-aDaSvL7evbCWoQ6W7H1i Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 1321 On Thu, 2004-01-29 at 16:19, Andrew Cagney wrote: > > Andrew Cagney writes: > > > Hello, > > > > > > Ref: RFA symtab: Fix for PR c++/1267 ("next" and shared libraries) > > > http://sources.redhat.com/ml/gdb-patches/2003-07/msg00354.html > > > > > > The change unfortunatly broke IRIX 6.5's host compiler which is using > > > mdebugread :-( That code was looking for a symbol in the absolute > > > section "*ABS*" but the PR/1267 change was causing *ABS* symbols to be > > > ignored (find_pc_section didn't return an absolute section). > > > > > > Since the underlying problem with PR/1267 was with the frame code > > > needing a minimal symbol that was in the same section as the frame's PC, > > > and that code [indirectly] calls lookup_minimal_symbol_by_pc, I moved > > > the find_pc_section call to that function. > > > > > > Tested on i386 GNU/Linux (dwarf 2) with no regressions. > > > Tested on PPC NetBSD (stabs) with no regressions. > > > Tested on IRIX and all the warnings, and many failures, disappeared. > > > See gdb/1519 for how to exercise the bug. > > > > > > ok? > > > > ok. Does it still fix shlibs/1237 and shlibs/1280 too? Adam, could you > > check please? > > Isn't that covered by the testsuite? Sigh. > This is probably ugly, but it shows the basic idea... --=-aDaSvL7evbCWoQ6W7H1i Content-Disposition: attachment; filename=sh1280test.patch Content-Type: text/x-patch; name=sh1280test.patch; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 4490 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/testsuite/ChangeLog,v retrieving revision 1.769 diff -u -r1.769 ChangeLog --- ChangeLog 29 Jan 2004 11:15:42 -0000 1.769 +++ ChangeLog 30 Jan 2004 04:50:33 -0000 @@ -1,3 +1,8 @@ +2004-01-29 Adam Fedor + + * gdb.base/ppc-shared.exp: New file. + * gdb.base/ppc-main.c, gdb.base/ppc-shared.c: New files. + 2004-01-29 Paul N. Hilfinger * gdb.base/chng-syms.exp: New file. Index: gdb.base/ppc-main.c =================================================================== RCS file: gdb.base/ppc-main.c diff -N gdb.base/ppc-main.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ gdb.base/ppc-main.c 30 Jan 2004 04:50:33 -0000 @@ -0,0 +1,8 @@ +extern int hithere2 (); + +int +main() +{ + hithere2(); + return 0; +} Index: gdb.base/ppc-shared.c =================================================================== RCS file: gdb.base/ppc-shared.c diff -N gdb.base/ppc-shared.c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ gdb.base/ppc-shared.c 30 Jan 2004 04:50:33 -0000 @@ -0,0 +1,5 @@ +int hithere2() +{ + return 21; +} + Index: gdb.base/ppc-shared.exp =================================================================== RCS file: gdb.base/ppc-shared.exp diff -N gdb.base/ppc-shared.exp --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ gdb.base/ppc-shared.exp 30 Jan 2004 04:50:33 -0000 @@ -0,0 +1,98 @@ +# Copyright 2003 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ + +# Please email any bugs, comments, and/or additions to this file to: +# bug-gdb@prep.ai.mit.edu + +# ppc-shared.exp -- Test stepping into and continuing to a function in +# a shared library (PR shlib/1280, shlib/1237). + +if $tracelevel then { + strace $tracelevel +} + +set testfile ppc-main +set libfile ppc-shared +set srcfile ${testfile}.c +set binfile ${objdir}/${subdir}/${testfile} + +remote_exec build "rm -f ${binfile}" + +# get the value of gcc_compiled +if [get_compiler_info ${binfile}] { + return -1 +} + +if { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}.o" object {debug}] != "" } { + return -1 +} + +# Build the shared libraries this test case needs. +# + +if {$gcc_compiled == 0} { + if [istarget "hppa*-hp-hpux*"] then { + set additional_flags "additional_flags=+z" + } elseif { [istarget "mips-sgi-irix*"] } { + # Disable SGI compiler's implicit -Dsgi + set additional_flags "additional_flags=-Usgi" + } else { + # don't know what the compiler is... + set additional_flags "" + } +} else { + if { ([istarget "powerpc*-*-aix*"] + || [istarget "rs6000*-*-aix*"]) } { + set additional_flags "" + } else { + set additional_flags "additional_flags=-fpic" + } +} + +set additional_flags "$additional_flags -shared" +if {[gdb_compile "${srcdir}/${subdir}/${libfile}.c" "${objdir}/${subdir}/${libfile}.so" executable [list debug $additional_flags "incdir=${objdir}"]] != ""} { + return -1 +} + +if { ($gcc_compiled +&& ([istarget "powerpc*-*-aix*"] +|| [istarget "rs6000*-*-aix*"] )) } { + set additional_flags "additional_flags=-L${objdir}/${subdir}" +} elseif { [istarget "mips-sgi-irix*"] } { + set additional_flags "additional_flags=-rpath ${objdir}/${subdir}" +} else { + set additional_flags "" +} + +if {[gdb_compile "${objdir}/${subdir}/${testfile}.o ${objdir}/${subdir}/${libfile}.so" "${binfile}" executable [list debug $additional_flags]] != ""} { + return -1 +} + + +gdb_exit +gdb_start +gdb_reinitialize_dir $srcdir/$subdir +gdb_load ${binfile} + +if ![runto_main] then { + fail "Can't run to main" + return 0 +} + +gdb_test s \ + "hithere2 \\(\\) at.*${libfile}.c:3\r\n3.*return 21.*" \ + "Step into shared lib function" + --=-aDaSvL7evbCWoQ6W7H1i--