From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24144 invoked by alias); 30 Jan 2004 03:30:05 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24091 invoked from network); 30 Jan 2004 03:30:04 -0000 Received: from unknown (HELO external2.doc.com) (199.72.38.17) by sources.redhat.com with SMTP; 30 Jan 2004 03:30:04 -0000 Received: (qmail 27800 invoked from network); 30 Jan 2004 03:30:03 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO ?192.168.1.101?) (24.221.209.215) by external2.doc.com with SMTP; 30 Jan 2004 03:30:03 -0000 Subject: Re: [rfa/symtab] Move find_pc_section call to lookup_minimal_symbol_by_pc From: Adam Fedor To: Andrew Cagney Cc: Elena Zannoni , "gdb-patches@sources.redhat.com" In-Reply-To: <401994EE.9060306@gnu.org> References: <4016E401.2050001@gnu.org> <16409.26976.292424.689823@localhost.redhat.com> <401994EE.9060306@gnu.org> Content-Type: text/plain Organization: Message-Id: <1075433401.29217.9.camel@localhost.localdomain> Mime-Version: 1.0 Date: Fri, 30 Jan 2004 03:30:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2004-01/txt/msg00755.txt.bz2 On Thu, 2004-01-29 at 16:19, Andrew Cagney wrote: > > Andrew Cagney writes: > > > Hello, > > > > > > Ref: RFA symtab: Fix for PR c++/1267 ("next" and shared libraries) > > > http://sources.redhat.com/ml/gdb-patches/2003-07/msg00354.html > > > > > > The change unfortunatly broke IRIX 6.5's host compiler which is using > > > mdebugread :-( That code was looking for a symbol in the absolute > > > section "*ABS*" but the PR/1267 change was causing *ABS* symbols to be > > > ignored (find_pc_section didn't return an absolute section). > > > > > > Since the underlying problem with PR/1267 was with the frame code > > > needing a minimal symbol that was in the same section as the frame's PC, > > > and that code [indirectly] calls lookup_minimal_symbol_by_pc, I moved > > > the find_pc_section call to that function. > > > > > > Tested on i386 GNU/Linux (dwarf 2) with no regressions. > > > Tested on PPC NetBSD (stabs) with no regressions. > > > Tested on IRIX and all the warnings, and many failures, disappeared. > > > See gdb/1519 for how to exercise the bug. > > > > > > ok? > > > > ok. Does it still fix shlibs/1237 and shlibs/1280 too? Adam, could you > > check please? > > Isn't that covered by the testsuite? Sigh. I'll try to write a testcase.