Re: [PATCH] Remove "\nError: " suffix from nat/fork-inferior.c:trace_start_error warning message

Sergio Durigan Junior
2019-08-30T21:06:10Z

On Friday, August 30 2019, Pedro Alves wrote:

> On 8/30/19 8:51 PM, Sergio Durigan Junior wrote:
>> Rationale: https://sourceware.org/ml/gdb-patches/2019-08/msg00651.html
>>
>> This very simple patch removes the "\nError: " suffix from the warning
>> message printed by nat/fork-inferior.c:trace_start_error. This proved
>> to just pollute the screen, causing things like:
>>
>> Starting program: /usr/bin/true
>> warning: Could not trace the inferior process.
>> Error:
>> warning: ptrace: Permission denied
>>
>> This "Error: " string is not useful at all, and can confuse things,
>> therefore let's just remove it and simplify the resulting messages:
>>
>> Starting program: /usr/bin/true
>> warning: Could not trace the inferior process.
>> warning: ptrace: Permission denied
>>
>> 2019-08-29 Sergio Durigan Junior <sergiodj@redhat.com>
>>
>> * nat/fork-inferior.c (trace_start_error): Remove "\nError: "
>> suffix from warning message.
>
> OK.

Thanks, pushed: 47a536d940d2f2bccfec51539b857da06ebc429e

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible