[PATCH][gdb/testsuite] Log wait status on process no longer exists error

[Tom de Vries <tdevries@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 774 bytes --]

[ was: Re: [PATCH][gdb/testsuite] Rewrite catch-follow-exec.exp ]
On 10/24/18 1:47 PM, Tom de Vries wrote:
>> I'd suggest replacing
>>
>>     gdb_test_multiple "info prog" "info prog" {
>> 	-i "$gdb_spawn_id" eof {
>> 	    fail "info prog"
>> 	}
>> 	-i "$gdb_spawn_id" "No selected thread\."  {
>> 	    pass "info prog"
>> 	}
>>     }
>>
>> with the simpler
>>
>>     gdb_test "info prog" "No selected thread."
>>
>> If GDB crashes as it did before your fix, the test will be unresolved, which is
>> treated the same as a FAIL.
> Done.
> 

Btw, I noticed that gdb_test_multiple emits an "ERROR: Process no longer
exists" preceding the unresolved message, but does not give details
about the process exit status, which might be helpful.

How about this patch?

Thanks,
- Tom

[-- Attachment #2: 0001-gdb-testsuite-Log-wait-status-on-process-no-longer-exists-error.patch --]
[-- Type: text/x-patch, Size: 1471 bytes --]

[gdb/testsuite] Log wait status on process no longer exists error

Proc gdb_test_multiple can run into a process no longer exists error, but when
that happens it shows no details about the process:
...
ERROR: Process no longer exists
...

Fix this by showing the wait status of the process in the log:
...
ERROR: Gdb process no longer exists
Gdb process exited with wait status 8106 exp8 0 0 CHILDKILLED SIGSEGV \
  {segmentation violation}
...

In order to run the wait commmand we need an explicit pid, so we can't use
any_spawn_id, and duplicate the "-i any_spawn_id eof" patter for gdb_spawn_id,
and add the wait status logging there.

Build and tested on x86_64-linux.

2018-10-24  Tom de Vries  <tdevries@suse.de>

	* lib/gdb.exp (gdb_test_multiple): Log wait status on process no
	longer exists error.

---
 gdb/testsuite/lib/gdb.exp | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 2d197d9b5c..f68664b0ef 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -980,6 +980,16 @@ proc gdb_test_multiple { command message user_code } {
 	    set result -1
 	}
 
+	-i $gdb_spawn_id
+	eof {
+	    perror "Gdb process no longer exists"
+	    verbose -log "Gdb process exited with wait status [wait -i $gdb_spawn_id]"
+	    if { $message != "" } {
+		fail "$message"
+	    }
+	    return -1
+	}
+
 	# Patterns below apply to any spawn id specified.
 	-i $any_spawn_id
 	eof {