From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6367 invoked by alias); 19 Jun 2003 20:33:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31062 invoked from network); 19 Jun 2003 20:29:45 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 Jun 2003 20:29:45 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5JKTiH15823 for ; Thu, 19 Jun 2003 16:29:44 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5JKTiI19066; Thu, 19 Jun 2003 16:29:44 -0400 Received: from [150.1.200.14] (vpn50-66.rdu.redhat.com [172.16.50.66]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5JKThd23831; Thu, 19 Jun 2003 16:29:44 -0400 Subject: Re: [RFA] varobj: call CHECK_TYPEDEF From: Keith Seitz To: Daniel Jacobowitz Cc: "gdb-patches@sources.redhat.com" In-Reply-To: <20030619194513.GA7225@nevyn.them.org> References: <1051215397.1538.43.camel@lindt.uglyboxes.com> <3EA84A9B.5020308@redhat.com> <1051221433.1534.72.camel@lindt.uglyboxes.com> <3EA8629B.50603@redhat.com> <1055362509.1571.63.camel@lindt.uglyboxes.com> <1055378162.1571.98.camel@lindt.uglyboxes.com> <20030612012810.GA21583@nevyn.them.org> <20030619192845.GA2379@nevyn.them.org> <20030619194513.GA7225@nevyn.them.org> Content-Type: text/plain Organization: Message-Id: <1056055095.1577.10.camel@lindt.uglyboxes.com> Mime-Version: 1.0 Date: Thu, 19 Jun 2003 20:33:00 -0000 Content-Transfer-Encoding: 7bit X-SW-Source: 2003-06/txt/msg00639.txt.bz2 On Thu, 2003-06-19 at 12:45, Daniel Jacobowitz wrote: > > That doesn't dereference pointers and references! It looks like > > get_type got inserted between get_type_deref and its comments? Can you > > confirm that it shouldn't dereference? Yes, I believe the comment is wrong. There is another function to do dereferences... > I take that back. Test results are abominable; everything crashes > because I misunderstood the use of get_target_type. Try this patch. Your patch passes all the insight varobj tests (c_variable.exp, cpp_variable.exp, insight219.exp). We still have the one (existing) failure, as expected (aka: gcc bug, as I recall). Anyway, I would like to encourage you to check this patch in (and you could close insight/219, too :-) Keith