Re: [RFA] varobj: call CHECK_TYPEDEF

Daniel Jacobowitz
2003-06-19T20:43:12Z

On Thu, Jun 19, 2003 at 01:38:16PM -0700, Keith Seitz wrote:
> On Thu, 2003-06-19 at 12:45, Daniel Jacobowitz wrote:
> > > That doesn't dereference pointers and references! It looks like
> > > get_type got inserted between get_type_deref and its comments? Can you
> > > confirm that it shouldn't dereference?
>
> Yes, I believe the comment is wrong. There is another function to do
> dereferences...
>
> > I take that back. Test results are abominable; everything crashes
> > because I misunderstood the use of get_target_type. Try this patch.
>
> Your patch passes all the insight varobj tests (c_variable.exp,
> cpp_variable.exp, insight219.exp). We still have the one (existing)
> failure, as expected (aka: gcc bug, as I recall).
>
> Anyway, I would like to encourage you to check this patch in (and you
> could close insight/219, too :-)

I've checked it in. I can't edit the insight PR database, though.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer