From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id C+KfCQ5pDWCXYQAAWB0awg (envelope-from ) for ; Sun, 24 Jan 2021 07:33:18 -0500 Received: by simark.ca (Postfix, from userid 112) id 11C461EF80; Sun, 24 Jan 2021 07:33:18 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A91991E945 for ; Sun, 24 Jan 2021 07:33:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A9C50385783A; Sun, 24 Jan 2021 12:33:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A9C50385783A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611491595; bh=GvSKXdwrp7NI7X55CtSQi1nLJrLWsdt2GDnqnKkYlFE=; h=Date:To:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=rKgg0mT4xASaTa+FivYwyszzdP6NpvSblSMSbqAu+Wi6Dz19MFjWr1mMVdAbcIgYT UJlqj9fRZEcO3s85TUdlw0RirWJowBe2IxHG4YjscTJJ6ZXDVaSC4j6fwpbhbE38N8 fVGVfRGK9ibbp16+C3/qJqXgpWYkJ64FURolicus= Received: from sonic302-20.consmr.mail.ir2.yahoo.com (sonic302-20.consmr.mail.ir2.yahoo.com [87.248.110.83]) by sourceware.org (Postfix) with ESMTPS id 2FC73385783A for ; Sun, 24 Jan 2021 12:33:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 2FC73385783A X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1611491591; bh=JGjDschUVgd+VUyh+D2Z9UKWKAUw6DwAAvgGH5VhEL+=; h=Date:From:To:Subject:From:Subject:Reply-To; b=KiFqHAzmaac8kDQqoPRWY4fW2dzMbcwQvcIqEjyDarMtU39CFcoOYz93AbeTXB1V0BztYAX+xnjEHU4rrNqzPkUW5JeRiu8NL8i66xYWT2IZiki633aeBRzvk6aK+SjYc32GDsV4BeG5pBjdUXZZF2sBemA1DYz41cC8LNDn2lYg8TwHtPFv/cbxEBEj3vpz67oXsSGI7NofulqkXyV2NbWUs5Xz50ZWs31tzPj8Cerla6PbjXgniLkQQpFPqs224l5iXTaNE7hh2BXMe+yJ0a5wST2zpGwoKgDKigMrhWL8YMkurd505VTapGGTIxz9MG+NObBXi4cFhi+V0itQ4A== X-YMail-OSG: cDXjftgVM1lNFc.9eZ_JVUjXEIVdNaWuAeklEuCZuEyXG8rYM65zeaU1NGgOP1h 4CXNTHtVzN4d8pxgEP1vlHBUr_pKINKN7U8vBXdMVyqE5.wS6VCuPTN5Tfbr6qUriATx8gABoB6t wP7vgTahIbbpcVsyAjtLE6sT41sM_bxopzmfhLzkhqunDBFdo8tmdYIMeL_5b_uhs64pih4c2Dig sb0YzcStt7St99rzhKGgWyEI0RT0CO0oIMObFaovNkbj8J9_ekcvdWSPH1XE5fkmY6W7Rs2tkt8d D8rF9PeCrTCBAc.gY35LeRt492au6GXvosDQHaZeVltXOZ6qwMW4HIcvC990hmbgrpgI6Y.reG7r 5GtxK4xJ35Fk_scUHDZYlj3TKS9ApuhY1odD8AdJFrYx5HAGv3VrTjyjrnm1AATZHePeZIAb_Kme pTzy6dFfgTDaVKTvm.njXYGtvmdiN1OnzczOJ6DFSRH2ewwqg1cEi_qXe9UCF1TrWCTJvgpw7Gcb DRlpV7bnIS1_1RwkI1dW10GSUmycgxNbKwIfo4tMwd.8JJkps3EQ6RjqEd22W0B8rbq_8vj6rWvM ZrX9rQIuu5eaRj_IF2P9JAIRmbzeq3SKM4kPYBxwSk307ZNEx3NXuvkjYcFU9B0S0LU02Pg5R8KJ 4Ne8C.HUgzL0zflRc3FndFMdr6XqV9tWs6QBRfF08fNb11siWRE7uIBE3gHUVUDa1nGql6a4.Jkq 3.qOoR3.iascfFj7LIfa5U4iSjkv74s8Nmb241wtTWGZZNZyrFYIjn1JEIwQlI9CU0Ej60gjF9Zh 1WODVUJbq9nfNmvebxF0KW_HX0F_goeUYON1Qj75rLVnkYKMaDAPMGoHPRJexnbWx4vnO3khjzbG 7g0i6TbnDxm0azCdhmMob1sOz2zO812UZUagq2O2cjV_kvuCJ4hdwBB0lcgNuYJ1QWAGLNYO9xNG g4Voj_Q.3rCz8DPZkTopmOsF4GLL11C8Q4jBTITPCikUfMX5Bh_2QJphmc9xTfLKyWPdLowLZDXA rTIsXQg3K1DcYIHQvJ.yIsBjaBGVFhvumPeV_hmdmSYb9yeGQEEjP5xCJWQAIxiVtQN1ETv_itGV UYpv3_DafgMtGTv138jstEZFMRsbk3B0huQKFBwhQwoP2aLpuv94mkJz.ydaAp32UMP3LvKsslU4 iE9seqsiyhZnvunFicHfcuAKkm0u3EyDL80kMzvfEsqiWLFflrYO9fRmQWEFzGg8RbvOP7yX5dms Ey.6T1O8msvvGvHcxOOkgsAddrHWvudp9UsDBlVV0auGlDaLdvy.AKc3JrzwQ0o_A.v_0IOaAUzh 0IT4yywUdWH61BBIU9VmB9SuPueI11QZd1VAueh7t_L2ZtCJ75QytucegWbQgU9HGURzzfwMZp8_ YqyzQObMVvFknUtb9oGUMYE9g8QFZ4JvjabEy5dZQSl9hlkqECt2AcFQTgw.02ABQvOPKqqraqv2 lLhd4xqZiJc8qsM_xFfV7w_LQyXzb89.7JUfV8IYxYobXf4EQJHFqxnVti_o6u8Zg7X1KDqnLBgu d9jbk391q7mNB5DxBMngennDx488ZsIktiFRwFdyQpDvF4PYin0bSlllPmWW6W5Rr0irBaPIc_KE QGQ0nsfkMlX8itAV2JH.MS2nkRJkRgMHrXf13vD_1f3Adn_3AmM8l5ZUrCj7kJ.mh73mv5BEvNlV A0ADZNOii7KKJglw_LdGJmFqVAo8CBp.QNYAf0srXrr3tZ8cevG0f9yITIZI58UvYDFGx3G5XdH5 .G9eyeRckjXhnaVOGvBzQLT7D.rx6PbSL1fVpWr4SF7uYMAyEP5NEnmKKRsMRkGdz4W_oZJ0EsV5 9v1Ck7J1whuxTX97K6FIHygr2JTXKAM7Ki20GJHYbQtikFfdgnv751qoqFcWBqV0hKTrzik6rvFZ R2HnGLUnEW4Q7E9vlzshliGQzFfmJO2L85CUolwbYO0L8qePcXix0b_GqNej41sqQaO1oSlidXgX U4GU4CHzTxLOaELOpmkoIvF1P1HyCkuAPInQzseVhvoQpy5mbAArFKj2PTCxgUq9sSLEmiXtCGd6 FpvXoBVKTF0mjt6HluyurOamqXxA917qaK6oGGcJ2hGKdCcINg3lP0rAnZDT.S16A_hTvMh1d37Q exE6mEUmRLA__qfwBL0S84IdYOR8TtvuDpmfTGScUltEyOGvGb3raRtugFda5ajnvQkTJyePnNTi .ddfAACxbsk9L3UjVbEBmd4FNrUoyTsBj9TWLvVQi1hR__VvGnLK_p1WOQ_2EKZHkBEvMPQ_NAJ_ GhFPAEQ3fxgQJRFAgfhPEVU8vCtuqlUPOBvp.CJJH..ZJEIa03AC_FSfrxxxmT4QbbHBx2fHL2Q2 m.KxyPu7RDb1aBgjmykkWIub_b5MxWdO2H1OX3FCQ7ttvmGgpC6gkCAZr_d1G6eiT9yAm..zZdNH ea.3lA1X8TkpAGVahs2RKpwrWDGlmXZaRDMWbv4LQBCtSbXncOzc_u2nH6.jkAQqEqC5e88ickyQ mxczGnTe6zQRFt9WDv8GCnKhX9eoWt6b6rqMtQX0qVzH1Qe3Uz1tb8gSxRO9djCjKixBu28nuIhD tNcjhZwXBPTGhyXYrxs6sqpilR9mwTC.D6j4c5C14 Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ir2.yahoo.com with HTTP; Sun, 24 Jan 2021 12:33:11 +0000 Date: Sun, 24 Jan 2021 12:33:09 +0000 (UTC) To: Andrew Burgess Message-ID: <1037951634.883244.1611491589308@mail.yahoo.com> In-Reply-To: <20210123175551.GD265215@embecosm.com> References: <20201229170227.821-1-ssbssa@yahoo.de> <20201229170227.821-2-ssbssa@yahoo.de> <20210115164811.GK265215@embecosm.com> <20210117113102.GM265215@embecosm.com> <2060671008.4946685.1610889581434@mail.yahoo.com> <20210123175442.GC265215@embecosm.com> <20210123175551.GD265215@embecosm.com> Subject: Re: [PATCH 2/4] Return true in TuiWindow.is_valid only if TUI is enabled MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.17501 YMailNorrin Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:76.0) Gecko/20100101 Firefox/76.0 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hannes Domani via Gdb-patches Reply-To: Hannes Domani Cc: Tom Tromey , "gdb-patches@sourceware.org" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Am Samstag, 23. Januar 2021, 18:55:56 MEZ hat Andrew Burgess Folgendes geschrieben: > * Andrew Burgess [2021-01-23 17:54:42 +0000= ]: > > > * Hannes Domani [2021-01-17 13:19:41 +0000]: > > > > >=C2=A0 Am Sonntag, 17. Januar 2021, 12:31:05 MEZ hat Andrew Burgess Folgendes geschrieben: > > > > > > > After further though I think there's an even better solution for th= is > > > > issue.=C2=A0 See the patch below. > > > > > > This version crashes for me when I disable and then re-enable TUI, be= cause > > > tui_windows and tui_win_list are empty, not filled again in tui_enabl= e, and the > > > tui_update_gdb_sizes call at the end of tui_enable dereferences TUI_C= MD_WIN. > > > > > > Also, and I think your previous patch behaves the same, but I can no = longer use > > > the TuiWindows variables width/height/title inside my Window.close fu= nction, > > > because at this point tui_active=3D=3Dfalse, so the assertion inside = is_valid > > > fails. > > > This can be worked around by saving the values in some Window class m= embers, > > > but it is more inconvenient. > > > > Hannes, > > > > Would you be able to give the version below a try please and let me > > know if you are still seeing any problems. > > > > This is much more like the first patch I posted. > > > > I honestly think the second approach is better, but it throws up so > > many other issues that would need to be resolved around the whole > > disable/enable transition, that I think going with the first approach > > is just going to be simpler. > > > > Anyway, I think this covers all the situations you've described so > > far, but let me know if you still see any issues. > > > > Thanks, > > Andrew > > Might help if I included the patch :) Yes, with this I have seen no problems so far. Hannes