From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127835 invoked by alias); 5 Nov 2016 14:55:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127824 invoked by uid 89); 5 Nov 2016 14:55:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=baldwin, Baldwin, thursday, Thursday X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 05 Nov 2016 14:55:50 +0000 Received: from ralph.baldwin.cx (c-73-231-226-104.hsd1.ca.comcast.net [73.231.226.104]) by mail.baldwin.cx (Postfix) with ESMTPSA id 0C97A10AFA0; Sat, 5 Nov 2016 10:55:48 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Walfred Tedeschi , palves@redhat.com, eliz@gnu.org, brobecker@adacore.com Subject: Re: [PATCH 2/2] amd64-linux: expose system register FS_BASE and GS_BASE for Linux. Date: Sat, 05 Nov 2016 14:55:00 -0000 Message-ID: <10348831.DcNpOF0W33@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.0-PRERELEASE; KDE/4.14.10; amd64; ; ) In-Reply-To: <1478166445-21370-3-git-send-email-walfred.tedeschi@intel.com> References: <1478166445-21370-1-git-send-email-walfred.tedeschi@intel.com> <1478166445-21370-3-git-send-email-walfred.tedeschi@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00108.txt.bz2 On Thursday, November 03, 2016 10:47:25 AM Walfred Tedeschi wrote: > diff --git a/gdb/amd64-linux-tdep.c b/gdb/amd64-linux-tdep.c > index 3f2a92b..a8a0b79 100644 > --- a/gdb/amd64-linux-tdep.c > +++ b/gdb/amd64-linux-tdep.c > @@ -1872,6 +1881,18 @@ amd64_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) > tdesc = tdesc_amd64_linux; > tdep->tdesc = tdesc; > > + feature = tdesc_find_feature (tdesc, "org.gnu.gdb.i386.segments"); > + if (feature != NULL) > + { > + struct tdesc_arch_data *tdesc_data_segments > + = (struct tdesc_arch_data *) info.tdep_info; > + > + tdesc_numbered_register (feature, tdesc_data_segments, > + AMD64_FSBASE_REGNUM, "fs_base"); > + tdesc_numbered_register (feature, tdesc_data_segments, > + AMD64_GSBASE_REGNUM, "gs_base"); > + } > + > feature = tdesc_find_feature (tdesc, "org.gnu.gdb.i386.linux"); > if (feature == NULL) > return; Should this be done in the OS-independent amd64_init_abi() instead? FreeBSD also has ptrace operations to get/set the FS and GS base registers (which I will add as a followup once this series is committed). -- John Baldwin