From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21394 invoked by alias); 29 May 2019 15:25:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21381 invoked by uid 89); 29 May 2019 15:25:20 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=H*RU:209.85.221.65, HX-Spam-Relays-External:209.85.221.65 X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 May 2019 15:25:18 +0000 Received: by mail-wr1-f65.google.com with SMTP id x4so2095249wrt.6 for ; Wed, 29 May 2019 08:25:18 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4eeb:42ff:feef:f164? ([2001:8a0:f913:f700:4eeb:42ff:feef:f164]) by smtp.gmail.com with ESMTPSA id o12sm8147202wmh.12.2019.05.29.08.25.15 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Wed, 29 May 2019 08:25:15 -0700 (PDT) Subject: Re: [PATCH 20/24] Make "frame apply" support -OPT options To: Philippe Waroquiers , gdb-patches@sourceware.org References: <20190522205327.2568-1-palves@redhat.com> <20190522205327.2568-21-palves@redhat.com> <1558815166.1454.24.camel@skynet.be> <7dbb69b0-ac98-eaa0-fb41-cbe2e2faa929@redhat.com> From: Pedro Alves Message-ID: <10333ae5-0a24-1281-584a-fcfb6246acf4@redhat.com> Date: Wed, 29 May 2019 15:25:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <7dbb69b0-ac98-eaa0-fb41-cbe2e2faa929@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-05/txt/msg00640.txt.bz2 On 5/29/19 4:13 PM, Pedro Alves wrote: > On 5/25/19 9:12 PM, Philippe Waroquiers wrote: >>> -# Run the print integration tests. >>> -test-print "" >>> +# Run the print integration tests, both as "standalone", and under >>> +# "frame apply". The latter checks that the "frame apply ... COMMAND" >>> +# commands recurse the completion machinery for COMMAND completion >> Not very clear what commands (with s) we speak about here ... >> > > I meant all of "frame apply COUNT|level|all", which are implemented > as separate commands. I've changed it like this: > > # Run the print integration tests, both as "standalone", and under > -# "frame apply". The latter checks that the "frame apply ... COMMAND" > -# commands recurse the completion machinery for COMMAND completion > -# correctly. > +# "frame apply COUNT|all|level". The latter checks that the "frame > +# apply COUNT|all|level COMMAND" commands recurse the completion > +# machinery for COMMAND completion correctly. Hmm, in the "thread apply" patch (patch #22), I was changing this comment to: # Run the print integration tests, both as "standalone", and under -# "frame apply". The latter checks that the "frame apply ... COMMAND" -# commands recurse the completion machinery for COMMAND completion -# correctly. +# "frame/thread apply". The latter checks that the "frame/thread +# apply ... COMMAND" commands recurse the completion machinery for +# COMMAND completion correctly. So I'm thinking that it's just simpler to leave it be as it was. Thanks, Pedro Alves