From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124221 invoked by alias); 4 Jun 2018 13:40:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123552 invoked by uid 89); 4 Jun 2018 13:40:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:GyC7-XJ, H*f:CAMe9rOox6mZ6MX, H*i:CAMe9rOox6mZ6MX, H*i:sk:GyC7-XJ X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 04 Jun 2018 13:40:20 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5594440BC05C; Mon, 4 Jun 2018 13:40:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3EF3963F58; Mon, 4 Jun 2018 13:40:18 +0000 (UTC) Subject: Re: [PATCH 2/3] Add DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION To: "H.J. Lu" , John Marshall References: <20180521121557.16535-1-hjl.tools@gmail.com> <20180521121557.16535-2-hjl.tools@gmail.com> <20180601101949.GA7660@bubble.grove.modra.org> <0d2578f3-f6c0-d19f-d036-fd07d1ff03d0@redhat.com> <2478bdec-0e72-ac94-aa97-8004999feb6e@redhat.com> Cc: Nick Clifton , Alan Modra , Binutils , GDB From: Pedro Alves Message-ID: <1032a2ef-e852-b30b-8d40-7ea64775e1a8@redhat.com> Date: Mon, 04 Jun 2018 13:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00064.txt.bz2 On 06/04/2018 02:30 PM, H.J. Lu wrote: > On Mon, Jun 4, 2018 at 5:46 AM, H.J. Lu wrote: >> On Mon, Jun 4, 2018 at 5:19 AM, Pedro Alves wrote: >>> On 06/04/2018 01:13 PM, Nick Clifton wrote: >>>> Hi H.J. >>>> >>>>> +# if __GNUC__ == 8 && __GNUC_MINOR__ < 2 >>>>> +# define DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION \ >>>>> + DIAGNOSTIC_IGNORE ("-Wstringop-truncation") >>>>> +# endif >>>>> >>>>> OK for master? >>>> >>>> Approved - please apply. >>> >>> Please don't. This is again going against the intention of >>> the header. The GCC version checks should be put in the >>> places where the warning needs to be suppressed. >>> The current patch makes all current and future uses of >>> DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION only apply to >>> GCC 8.1. That is incorrect. Consider what you will >>> have to do to suppress some -Wstrinop-truncation warning >>> with DIAGNOSTIC_IGNORE_STRINGOP_TRUNCATION on GCC 8.2 or >>> GCC 9 or whatever. >> >> This is what my original patch intended to do. But diagnostics.h from >> GDB doesn't support GCC version. Should I extend it to match glibc? >> >>> Also, you can use GCC_VERSION to make the version check >>> a little simpler. > > My second patch is needed for Darwin. I will check it in as is > and update it with a follow up patch to support GCC version. For the record, I think it would have been better procedure to split and push the DIAGNOSTIC_STRINGIFY bit only [1], while giving people reasonable time to respond to the rest. https://sourceware.org/ml/gdb-patches/2018-06/msg00062.html Thanks, Pedro Alves