Re: [commit] Deprecate remaining STREQ uses

Andrew Cagney
2003-12-01T15:47:02Z

>> Date: Thu, 27 Nov 2003 09:30:13 -0500
>> From: Andrew Cagney <cagney@gnu.org>
>>
>> If a contributor wants to add new code, or fix bugs in existing code,
>> they should not be increasing the use of existing deprecated mechanisms
>> (after all we should be able to reasonably expect contributors to not
>> make matters worse).
>
>
> But that's precisely why we have the patch review and approval
> procedure, right? Maintainers who approve patches are supposed to
> prevent code that uses deprecated machinery from being added.

Very true. Explicit deprecation is a tool for making that part of the
maintainer and contributor task far easier. Instead of wasting time
trying to track and find all the things being eliminated, the
contributor and reviewer can simply keep an eye out for deprecated in
their patches (and related calling). This then lets both parties focus
their attention and efforts on the real reason for the review - ensure
code quality and correctness.

Andrew