Re: [commit] Deprecate remaining STREQ uses

Andrew Cagney
2003-11-25T01:33:47Z

> On Nov 24, 3:32pm, Andrew Cagney wrote:
>
>
>> > I too would like to see discussion over whether a particular interface
>> > ought to be deprecated or outright replaced instead of presenting the
>> > renaming as a fait accompli.
>
>>
>> Please explain.
>
>
> This STREQ issue is a good example. You chose to post an already
> committed patch which did the renaming instead of first discussing the
> approaches by which STREQ could be eliminated. IMO, it would have been
> better to discuss the matter first and arrive at a consensus on how it
> should be eliminated. (Or even if it should be eliminated.)

Are you talking generally or just in terms of STREQ? STREQ is somewhat
a-typical in that my earlier "obish" s/STREQ/strcmp/ changes met with
zero comment (objection or thanks) - consequently I don't think it was
totally unreasonable of me to assume that deprecating the remainder
would be safe. It wasn't. "oops".

Andrew