From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 433 invoked by alias); 21 Nov 2003 20:11:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 371 invoked from network); 21 Nov 2003 20:11:39 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 21 Nov 2003 20:11:39 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hALKBcH07750 for ; Fri, 21 Nov 2003 15:11:38 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hALKBcw05676; Fri, 21 Nov 2003 15:11:38 -0500 Received: from localhost.localdomain (vpn50-29.rdu.redhat.com [172.16.50.29]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hALKBb89031673; Fri, 21 Nov 2003 15:11:37 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id hALKBWP17682; Fri, 21 Nov 2003 13:11:32 -0700 Date: Fri, 21 Nov 2003 20:11:00 -0000 From: Kevin Buettner Message-Id: <1031121201118.ZM17681@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "Re: [rfa:symtab] deprecate inside_entry_func" (Nov 21, 2:59pm) References: <3FA2F940.5040102@redhat.com> <3FBE6D46.4070201@redhat.com> <20031121195949.GA794@nevyn.them.org> To: Daniel Jacobowitz , Andrew Cagney Subject: Re: [rfa:symtab] deprecate inside_entry_func Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00444.txt.bz2 On Nov 21, 2:59pm, Daniel Jacobowitz wrote: > On Fri, Nov 21, 2003 at 02:53:42PM -0500, Andrew Cagney wrote: > > >Hello, > > > > > >This patch deprecates the function inside_entry_func. > > > > > >PS: Ref: http://sources.redhat.com/ml/gdb-patches/2003-10/msg00533.html > > > > Here's a revised patch. It now eliminates the [disabled] > > inside_entry_func call from "get_prev_frame", replacing it with the more > > direct [but equally disabled] get_frame_func() == entry_point_address() > > test. This way all calls to inside_entry_func have been eliminated from > > up-to-date code. > > > > Thoughts? Symtab ok? > > > > Andrew > > > > What Kevin and I have both repeatedly suggested, I think, is: > - Do not deprecate inside_entry_func; fix it if you don't like the > way it is implemented. Change the implementation. > - Deprecate entry_func_lowpc and entry_func_highpc (there's a typo in > your changelog, two lowpc's) if you really want to deprecate > something. > > The concept of inside_entry_func does not seem to be deprecated, so why > rename it? I agree with Daniel. Kevin