From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16119 invoked by alias); 7 Nov 2003 17:49:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 16097 invoked from network); 7 Nov 2003 17:49:32 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 7 Nov 2003 17:49:32 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA7HnWM25543 for ; Fri, 7 Nov 2003 12:49:32 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA7HnV618141; Fri, 7 Nov 2003 12:49:31 -0500 Received: from localhost.localdomain (vpn50-2.rdu.redhat.com [172.16.50.2]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hA7HnUH8007039; Fri, 7 Nov 2003 12:49:30 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id hA7HnOS17947; Fri, 7 Nov 2003 10:49:24 -0700 Date: Fri, 07 Nov 2003 17:49:00 -0000 From: Kevin Buettner Message-Id: <1031107174924.ZM17946@localhost.localdomain> In-Reply-To: Dave Brolley "Re: [RFA] FR-V SIM: Check availability of GR and FR regs" (Nov 7, 12:30pm) References: <1031107063317.ZM15719@localhost.localdomain> <3FABD6AC.5000806@redhat.com> To: Dave Brolley , Kevin Buettner Subject: Re: [RFA] FR-V SIM: Check availability of GR and FR regs Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00122.txt.bz2 On Nov 7, 12:30pm, Dave Brolley wrote: > I'm not sure if it's ok to include gdb/sim-frv.h from within the > simulator code. I thought the interface went the other way around (i.e. > gdb includes sim/frv-sim.h). Keep in mind that gdb/sim-frv.h is actually include/gdb/sim-frv.h. This file contains only those register numbers which are needed for sim <-> gdb interactions. The file sim/frv-sim.h contains quite a lot more. I'd be more than a little nervous including it in gdb's frv-tdep.c. Before embarking on this course, I did check for precedents. Here's what I found: sim/sh64/sh64.c[34]: #include "gdb/sim-sh.h" sim/sh/interp.c[32]: #include "gdb/sim-sh.h" sim/h8sx/compile.c[33]: #include "gdb/sim-h8300.h" sim/h8300/compile.c[33]: #include "gdb/sim-h8300.h" sim/d10v/interp.c[8]: #include "gdb/sim-d10v.h" sim/arm/wrapper.c[39]: #include "gdb/sim-arm.h" > Other than that, it looks ok to me. I'll wait until we've resolved the above to commit it. Kevin