From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6822 invoked by alias); 1 Nov 2003 00:55:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6814 invoked from network); 1 Nov 2003 00:55:24 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 1 Nov 2003 00:55:24 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id hA10tOM08272 for ; Fri, 31 Oct 2003 19:55:24 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id hA10tN630500 for ; Fri, 31 Oct 2003 19:55:23 -0500 Received: from localhost.localdomain (vpn50-2.rdu.redhat.com [172.16.50.2]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id hA10tMju030584; Fri, 31 Oct 2003 19:55:23 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id hA10tHu05151; Fri, 31 Oct 2003 17:55:17 -0700 Date: Sat, 01 Nov 2003 00:55:00 -0000 From: Kevin Buettner Message-Id: <1031101005517.ZM5150@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [rfa:symtab] deprecate inside_entry_func" (Oct 31, 7:46pm) References: <3FA2F940.5040102@redhat.com> <1031101003654.ZM5020@localhost.localdomain> <3FA30271.5020908@redhat.com> To: Andrew Cagney , Kevin Buettner Subject: Re: [rfa:symtab] deprecate inside_entry_func Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-11/txt/msg00006.txt.bz2 On Oct 31, 7:46pm, Andrew Cagney wrote: > > On Oct 31, 7:07pm, Andrew Cagney wrote: > > > >> This patch deprecates the function inside_entry_func. Per the new comments: > >> > >> + /* NOTE: cagney/2003-10-31: A very simple test, such as > >> + get_frame_func == entry_point should be sufficient for > >> + identifying a pc in the entry function. Does anyone know why it > >> + wasn't sufficient and hence, why the very convoluted > >> + "deprecated_inside_entry_func" is needed. */ > >> + /* NOTE: cagney/2003-10-31: An ABI and its crt0 code should define > >> + and implement a clean frame termination. Not doing that is > >> + really a bug in the ABI/crt0, and, hence, not a reason for > >> + enabling the call to deprecated_inside_entry_func. */ > > > > I do agree that it'd be nice if all ABIs provided a clean way to detect > > the bottom-most frame. Not all of them do however, and in such cases, > > a mechanism like inside_entry_func() is necessary. > > > So, in short, I oppose the deprecation of this function. > > Kevin, you previously wrote: > > >> I'd like to avoid re-introducing a dependency on inside_entry_func() as > >> that places garish requirements on the object file readers :-( > > > > I agree that object file readers should not attempt to track of > > the bounds of the start function. However, given an arbitrary > > address, it's not unreasonable to ask the symtab machinery to attempt > > to figure out the function bounds. And, in fact, this is just what > > find_pc_partial_function() does. Yes, the reason I wrote this was to note that there are other ways of implementing inside_entry_func() which wouldn't place garish requirements on the object file readers. Kevin