From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11763 invoked by alias); 28 Oct 2003 20:59:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11755 invoked from network); 28 Oct 2003 20:59:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 28 Oct 2003 20:59:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9SKxfM06567 for ; Tue, 28 Oct 2003 15:59:41 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9SKxf626751 for ; Tue, 28 Oct 2003 15:59:41 -0500 Received: from localhost.localdomain (vpn50-2.rdu.redhat.com [172.16.50.2]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9SKxeju028291; Tue, 28 Oct 2003 15:59:41 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h9SKxZ303487; Tue, 28 Oct 2003 13:59:35 -0700 Date: Tue, 28 Oct 2003 20:59:00 -0000 From: Kevin Buettner Message-Id: <1031028205935.ZM3486@localhost.localdomain> In-Reply-To: Andrew Cagney "[patch, rfa:ppc64, rfa:breakpoint] Add non-verbose breakpoint adjustment" (Oct 27, 12:39pm) References: <3F9D5864.50807@redhat.com> To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [patch, rfa:ppc64, rfa:breakpoint] Add non-verbose breakpoint adjustment MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00817.txt.bz2 On Oct 27, 12:39pm, Andrew Cagney wrote: > First the "adjust_breakpoint_address" interface is changed so that it > returns non-zero if GDB should warn the user of any breakpoint adjustment. I think this part is fine. (Don't forget about the docs though.) > It then modifies breakpoint.c to work with that new interface. And > ppc64 to provide a version of that interface that doesn't require any > warning. And this part too. > For breakpoint.c, I've also modified the warnings so that the warning: > > warning: Breakpoint 2 address previously adjusted from 0x104e5a60 to > 0x100895d0. > > no longer occures - I figure that the user will have noted it when the > breakpoint was set. It could also be made per-breakpoint? I would prefer that gdb issue warnings both at the time the breakpoint was set and when it gets hit. Or at least until we have more experience with it and find that the second warning unduly annoys users. How about calling gdbarch_adjust_breakpoint_address() to find out if the second warning should be printed? Alternately, we could add a field to the breakpoint struct, but this seems like overkill. Kevin