From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6821 invoked by alias); 23 Oct 2003 17:46:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6814 invoked from network); 23 Oct 2003 17:46:53 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 23 Oct 2003 17:46:53 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9NHkqM12586 for ; Thu, 23 Oct 2003 13:46:52 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9NHkor17118; Thu, 23 Oct 2003 13:46:50 -0400 Received: from localhost.localdomain (vpn50-2.rdu.redhat.com [172.16.50.2]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9NHklcY002306; Thu, 23 Oct 2003 13:46:48 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h9NHkgo14292; Thu, 23 Oct 2003 10:46:42 -0700 Date: Thu, 23 Oct 2003 17:46:00 -0000 From: Kevin Buettner Message-Id: <1031023174642.ZM14291@localhost.localdomain> In-Reply-To: "J. Johnston" "Re: RFA: ia64 tdep patch" (Oct 23, 12:22pm) References: <3F9049EF.8060209@redhat.com> <1031020201315.ZM20659@localhost.localdomain> <3F9459B6.5000909@redhat.com> <1031021222239.ZM26261@localhost.localdomain> <3F95BB43.1040703@redhat.com> <1031022193747.ZM31624@localhost.localdomain> <3F96EF3E.6070402@redhat.com> <3F96FE2C.3040308@redhat.com> <3F980050.4030101@redhat.com> To: "J. Johnston" Subject: Re: RFA: ia64 tdep patch Cc: Kevin Buettner , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00701.txt.bz2 On Oct 23, 12:22pm, J. Johnston wrote: > I have included a patch which contains responses to your comments thus far. > > The ChangeLog is: > > 2003-10-23 Jeff Johnston > * ia64-tdep.c: (ia64_frame_cache): Add new prev_cfm field. > (pseudo_regs): Add comment regarding register stack registers. > (ia64_alloc_frame_cache): Initialize new prev_cfm field to 0. > (floatformat_valid): New static routine. > (floatformat_ia64_ext): Add name field and set up is_valid routine > to floatformat_valid(). > (examine_prologue): For the previous cfm, use > frame_unwind_register() > if the cfm is not stored in a register-stack register. Save the > previous cfm value in the prev_cfm field. Add debug output. > (ia64_frame_this_id): Use frame_id_build_special() to also register > the bsp. Add debug output. > (ia64_sigtramp_frame_this_id): Ditto. > (ia64_frame_prev_register): Look at cache saved_regs for a few more > registers and also add some checks for framelessness before accepting > current register values for fields such as return address. For cfm, > use the cached prev_cfm field if available. Add comment to explain > PSR logic. Add debug output. > (ia64_sigtramp_frame_init_saved_regs): Bump up base by 16 to get > sp needed for calling lower level > ia64_linux_sigcontext_register_address(). Also save the > bsp and sp address as part of initialization. > (ia64_sigtramp_frame_cache): Hard-code stack size as it can't be > calculated. Cache the bsp and cfm values. > (ia64_sigtramp_frame_prev_register): Add logic to this routine out > instead of using ia64_frame_prev_register() which doesn't expect most > registers to be saved. The saved values for bsp and sp > can be taken from the cache. Add debug output. > (ia64_push_dummy_call): Use frame_id_build_special() to also register > the bsp. > > Ok? Okay. Kevin