Re: RFA: libunwind basic support

[Kevin Buettner <kevinb@redhat.com>]

On Oct 15,  5:29pm, J. Johnston wrote:

> The attached patch adds basic libunwind frame support.  I will be shortly 
> submitting an ia64-tdep.c patch which works in conjunction with this patch.  The 
> libunwind code is protected by looking for the libunwind header files to 
> compile.  At runtime, the libunwind frame sniffer will fail if either the 
> libunwind library cannot be dynamically loaded or the frame in question does not 
> have proper libunwind info.
> 
> For configuration I have added checks for libunwind.h and libunwind-ia64.h as 
> this is being added for ia64 support only at present.  Regarding testing, I have 
> this code working with my ia64 changes.  I have tested on systems with the 
> libunwind-0.92 library/headers installed and not installed.
> 
> Ok to commit?
> 
> 2003-10-15  Jeff Johnston  <jjohnstn@redhat.com>
> 
> 	* libunwind-frame.c: New file.
> 	* libunwind-frame.h: New file.
> 	* configure.in: Add checks for libunwind.h and libunwind-ia64.h.
> 	* configure: Regenerated.
> 	* Makefile.in: Add support for libunwind-frame.o.
> 	* config.in: Regenerated.

It looks okay to me.

I'm not sure who needs to approve this though -- if it's me, then you
have my approval.

Kevin