From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22688 invoked by alias); 10 Oct 2003 21:00:56 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22677 invoked from network); 10 Oct 2003 21:00:54 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Oct 2003 21:00:54 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h9AL0rM07758 for ; Fri, 10 Oct 2003 17:00:53 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h9AL0rc29833; Fri, 10 Oct 2003 17:00:53 -0400 Received: from localhost.localdomain (vpn50-39.rdu.redhat.com [172.16.50.39]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h9AL0q95009059; Fri, 10 Oct 2003 17:00:52 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h9AL0l632236; Fri, 10 Oct 2003 14:00:47 -0700 Date: Fri, 10 Oct 2003 21:00:00 -0000 From: Kevin Buettner Message-Id: <1031010210046.ZM32235@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [rfa?] Implement ppc32 SYSV {extract,store} return value" (Oct 10, 4:22pm) References: <3F68D829.6010001@redhat.com> <1030922215845.ZM29725@localhost.localdomain> <3F7F06D8.9000702@redhat.com> <1031006191231.ZM12230@localhost.localdomain> <3F8714F5.2030605@redhat.com> To: Andrew Cagney , Kevin Buettner Subject: Re: [rfa?] Implement ppc32 SYSV {extract,store} return value Cc: gdb-patches@sources.redhat.com, Jason R Thorpe MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg00382.txt.bz2 On Oct 10, 4:22pm, Andrew Cagney wrote: > How is the attached? Very close. I just noticed the following: + if ((TYPE_CODE (type) == TYPE_CODE_INT + && TYPE_LENGTH (type) == 8 + && tdep->wordsize == 4) + || (TYPE_CODE (type) == TYPE_CODE_FLT + && TYPE_LENGTH (type) == 8 && tdep->wordsize == 4)) According to do_ppc_sysv_return_value's comment, tdep->wordsize will have to be 4. (Since it's for the "SysV 32-bit PowerPC ABI...") So, could you please do the following: - Remove the ``tdep->wordsize == 4'' tests in the above expression. - Insert the following statement at some appropriate place at the beginning of the function: gdb_assert (tdep->wordsize == 4); Once that's done, it's okay. (Go ahead and check it in.) Thanks, Kevin