From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Cagney <ac131313@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:ppc] Cleanup SVR4 push dummy call
Date: Fri, 12 Sep 2003 17:56:00 -0000 [thread overview]
Message-ID: <1030912175624.ZM29278@localhost.localdomain> (raw)
In-Reply-To: Andrew Cagney <ac131313@redhat.com> "Re: [rfa:ppc] Cleanup SVR4 push dummy call" (Sep 12, 11:01am)
On Sep 12, 11:01am, Andrew Cagney wrote:
> * ppc-sysv-tdep.c (align_up, align_down): Replace "round2" macro.
> (ppc_sysv_abi_push_dummy_call): Rewrite, use a two pass loop.
Okay, except...
> ! else if (len == 8
> ! && (TYPE_CODE (type) == TYPE_CODE_INT /* long long */
> ! || (!ppc_floating_point_unit_p (current_gdbarch)
> ! && TYPE_CODE (type) == TYPE_CODE_FLT))) /* double */
> ! {
> ! /* "long long" or "double" passed in an odd/even
> ! register pair with the low addressed word in the odd
> ! register and the high addressed word in the even
> ! register, or when the registers run out an 8 byte
> ! aligned stack location. */
> ! if (greg > 9)
> ! {
> ! /* Just in case GREG was 10. */
> ! greg = 11;
> ! argoffset = align_up (argoffset, 8);
> ! write_memory (sp + argoffset, val, len);
...I believe you forgot the ``if (write_pass)'' check on the above
call to write_memory().
Kevin
next prev parent reply other threads:[~2003-09-12 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-09-12 14:47 Andrew Cagney
2003-09-12 15:02 ` Andrew Cagney
2003-09-12 17:56 ` Kevin Buettner [this message]
2003-09-12 18:33 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1030912175624.ZM29278@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=ac131313@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox