Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] dwarf2read.c: Add complaint for out of bounds DW_AT_ranges attribute
Date: Wed, 10 Sep 2003 21:20:00 -0000	[thread overview]
Message-ID: <1030910212021.ZM18957@localhost.localdomain> (raw)

This one's almost obvious...

GDB for the FR-V target was segfaulting when issued the "maint
check-symtabs" command.  Clearly this is an indication that something
is wrong with the toolchain elsewhere, but GDB should not segfault
when it encounters bad debug info.

Okay?

	* dwarf2read.c (dwarf2_get_pc_bounds): Complain if offset
	associated with DW_AT_ranges attribute is out of bounds.

Index: dwarf2read.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2read.c,v
retrieving revision 1.101
diff -u -p -r1.101 dwarf2read.c
--- dwarf2read.c	9 Sep 2003 23:23:05 -0000	1.101
+++ dwarf2read.c	10 Sep 2003 21:11:27 -0000
@@ -2253,7 +2253,7 @@ dwarf2_get_pc_bounds (struct die_info *d
 	  unsigned int addr_size = cu_header->addr_size;
 	  CORE_ADDR mask = ~(~(CORE_ADDR)1 << (addr_size * 8 - 1));
 	  /* Value of the DW_AT_ranges attribute is the offset in the
-	     .debug_renges section.  */
+	     .debug_ranges section.  */
 	  unsigned int offset = DW_UNSND (attr);
 	  /* Base address selection entry.  */
 	  CORE_ADDR base;
@@ -2266,6 +2266,14 @@ dwarf2_get_pc_bounds (struct die_info *d
  
 	  found_base = cu_header->base_known;
 	  base = cu_header->base_address;
+
+	  if (offset >= dwarf_ranges_size)
+	    {
+	      complaint (&symfile_complaints,
+	                 "Offset %d out of bounds for DW_AT_ranges attribute",
+			 offset);
+	      return 0;
+	    }
 	  buffer = dwarf_ranges_buffer + offset;
 
 	  /* Read in the largest possible address.  */


             reply	other threads:[~2003-09-10 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-09-10 21:20 Kevin Buettner [this message]
2003-09-13 17:53 ` Jim Blandy
2003-09-15 17:21   ` Kevin Buettner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030910212021.ZM18957@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox