Re: Patch to eliminate SOFTWARE_SINGLE_STEP from ppc Was: Powerpc and software single step

Daniel Jacobowitz
2003-09-08T20:20:10Z

On Mon, Sep 08, 2003 at 04:16:47PM -0400, Jimi Xenidis wrote:
> >>>>> "DJ" == Daniel Jacobowitz <drow@mvista.com> writes:
>
> DJ> On Mon, Sep 08, 2003 at 02:58:30PM -0400, Jimi Xenidis wrote:
> >> >>>>> "AC" == Andrew Cagney <ac131313@redhat.com> writes:
> >>
> AC> What about a patch to eliminate the macros? Good incremental step.
> >>
> >> Your wish is my (very much delayed) command ;-)
>
> DJ> Eh, no. This patch would turn on software single-step for GNU/Linux
>
> This patch simply removes the macro definitions. It does _not_ turn
> on software single step for GNU/Linux since the macro tests for the
> gdbarch vector which is NULL because it is undefined, but it is
> defined for AIX.
>
> I have verified this by both watching it with gdb and with strace
> output.

Are you sure you posted the patch you tested?

You added a call to set_gdbarch_software_single_step to
rs6000_gdbarch_init. It wasn't conditional on anything relating to
AIX. By all rights that _should_ set gdbarch_software_singlestep_p for
GNU/Linux.

>
> DJ> also I doubt that's what you wanted to do.
>
> You are right in that it is not what I wanted when this whole thing
> started, but it was suggested that I remove the macro before I propose
> the ability to select SW over HW at runtime.
>

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer