Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Mark Kettenis <kettenis@chello.nl>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA/i386]: Enable default support for SSE registers
Date: Tue, 12 Aug 2003 17:39:00 -0000	[thread overview]
Message-ID: <1030812173921.ZM21253@localhost.localdomain> (raw)
In-Reply-To: Mark Kettenis <kettenis@chello.nl> "Re: [RFA/i386]: Enable default support for SSE registers" (Aug 12,  7:06pm)

On Aug 12,  7:06pm, Mark Kettenis wrote:

>    Also... I just noticed the following bit of code in i387-tdep.c:
> 
>        i387_supply_register (int regnum, char *fsave)
>        {
> 	 if (fsave == NULL)
> 	   {
> 	     supply_register (regnum, NULL);
> 	     return;
> 	   }
> 
>    Calling supply_register() with NULL will end up calling memcpy() with
>    NULL as the second argument.  If memcpy() is told to copy a non-zero
>    number of characters, it'll SEGV.
> 
> Huh, If you call support_register() with NULL, it will use memset() to
> initialize the register with all zeroes.

My mistake.  The "tags" feature in my editor showed me the version in
gdbserver/regcache.c.

Kevin


      reply	other threads:[~2003-08-12 17:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-22 18:43 Kevin Buettner
2003-07-29 15:49 ` Kevin Buettner
2003-08-12 15:36   ` Mark Kettenis
2003-08-12 16:39     ` Kevin Buettner
2003-08-12 17:06       ` Mark Kettenis
2003-08-12 17:39         ` Kevin Buettner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030812173921.ZM21253@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kettenis@chello.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox