From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14223 invoked by alias); 12 Aug 2003 16:39:45 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 14212 invoked from network); 12 Aug 2003 16:39:44 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 12 Aug 2003 16:39:44 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h7CGdit03283 for ; Tue, 12 Aug 2003 12:39:44 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h7CGdhs27857; Tue, 12 Aug 2003 12:39:43 -0400 Received: from localhost.localdomain (vpn50-13.rdu.redhat.com [172.16.50.13]) by pobox.corp.redhat.com (8.12.8/8.12.8) with ESMTP id h7CGdhWt032370; Tue, 12 Aug 2003 12:39:43 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h7CGdbL20977; Tue, 12 Aug 2003 09:39:37 -0700 Date: Tue, 12 Aug 2003 16:39:00 -0000 From: Kevin Buettner Message-Id: <1030812163937.ZM20976@localhost.localdomain> In-Reply-To: Mark Kettenis "Re: [RFA/i386]: Enable default support for SSE registers" (Aug 12, 5:36pm) References: <1030722184305.ZM4145@localhost.localdomain> <1030729154932.ZM7867@localhost.localdomain> <863cg6riq5.fsf@elgar.kettenis.dyndns.org> To: Mark Kettenis Subject: Re: [RFA/i386]: Enable default support for SSE registers Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-08/txt/msg00197.txt.bz2 On Aug 12, 5:36pm, Mark Kettenis wrote: > There is one more concern that I do have: If we include > the SSE registers, we somehow should also set their values to > something sensible for targets that don't support them. We already do > this for Linux, but it makes more sense to add some code to > i387_supply_fsave(). I just took a quick look at this. It's not obvious to me what you have in mind. Would you mind taking care of this? Also... I just noticed the following bit of code in i387-tdep.c: i387_supply_register (int regnum, char *fsave) { if (fsave == NULL) { supply_register (regnum, NULL); return; } Calling supply_register() with NULL will end up calling memcpy() with NULL as the second argument. If memcpy() is told to copy a non-zero number of characters, it'll SEGV. > Go ahead and check this in on mainline. It's in. > Do you want it on the 6.0 branch too? It's not critical, but it'd be nice. Kevin