From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16990 invoked by alias); 19 Jun 2003 22:10:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31834 invoked from network); 19 Jun 2003 22:04:29 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 Jun 2003 22:04:29 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5JM4TH09350 for ; Thu, 19 Jun 2003 18:04:29 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5JM4TI17441; Thu, 19 Jun 2003 18:04:29 -0400 Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5JM4Sd01945; Thu, 19 Jun 2003 18:04:28 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h5JM4Nl04499; Thu, 19 Jun 2003 15:04:23 -0700 Date: Thu, 19 Jun 2003 22:10:00 -0000 From: Kevin Buettner Message-Id: <1030619220422.ZM4498@localhost.localdomain> In-Reply-To: Daniel Jacobowitz "Re: [Patch] arch recognition fix for osabi.c" (Jun 19, 3:08pm) References: <08c201c334e6$ccb8c750$0202040a@catdog> <20030617155147.GA25280@nevyn.them.org> <08d801c334ea$23fd99c0$0202040a@catdog> <20030619190853.GA25755@nevyn.them.org> To: Daniel Jacobowitz , Kris Warkentin Subject: Re: [Patch] arch recognition fix for osabi.c Cc: kettenis@gnu.org, "Gdb-Patches@Sources.Redhat.Com" MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-06/txt/msg00644.txt.bz2 On Jun 19, 3:08pm, Daniel Jacobowitz wrote: > All calls to gdbarch_register_osabi in GDB except for two use mach == > 0. The two are mips-linux-tdep.c, which appears to be solving the same > problem - what a coincidence: > for (arch_info = bfd_lookup_arch (bfd_arch_mips, 0); > arch_info != NULL; > arch_info = arch_info->next) > { > gdbarch_register_osabi (bfd_arch_mips, arch_info->mach, GDB_OSABI_LINUX, > mips_linux_init_abi); > } > and x86-64. For x86-64 your change is correct since BFD will catch the > different bits-per-word and return NULL. For mips-linux-tdep it would > let you remove that loop, which I have a vague memory of being annoyed > at when it became necessary. Yes, I wrote that loop, and I too was annoyed when I had to write it. Kevin