From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2583 invoked by alias); 11 Jun 2003 22:15:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2535 invoked from network); 11 Jun 2003 22:15:48 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Jun 2003 22:15:48 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h5BMFmH31253 for ; Wed, 11 Jun 2003 18:15:48 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5BMFlI31687; Wed, 11 Jun 2003 18:15:47 -0400 Received: from localhost.localdomain (vpn50-31.rdu.redhat.com [172.16.50.31]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h5BMFkE18652; Wed, 11 Jun 2003 18:15:46 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h5BMFf627026; Wed, 11 Jun 2003 15:15:41 -0700 Date: Wed, 11 Jun 2003 22:15:00 -0000 From: Kevin Buettner Message-Id: <1030611221540.ZM27025@localhost.localdomain> In-Reply-To: "J. Johnston" "RFA: patch to convert_doublest_to_floatformat in doublest.c" (Jun 10, 3:16pm) References: <3EE62E90.1000806@redhat.com> To: "J. Johnston" , gdb-patches@sources.redhat.com Subject: Re: RFA: patch to convert_doublest_to_floatformat in doublest.c MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-06/txt/msg00392.txt.bz2 On Jun 10, 3:16pm, J. Johnston wrote: > * doublest.c (convert_doublest_to_floatformat): When dealing with the implied > integer bit, only alter mant_bits if we are processing a full 32 bits of > mantissa. > > Index: doublest.c > =================================================================== > RCS file: /cvs/src/src/gdb/doublest.c,v > retrieving revision 1.15 > diff -u -p -r1.15 doublest.c > --- doublest.c 8 Jun 2003 18:27:13 -0000 1.15 > +++ doublest.c 10 Jun 2003 18:44:30 -0000 > @@ -404,7 +404,15 @@ convert_doublest_to_floatformat (CONST s > { > mant_long <<= 1; > mant_long &= 0xffffffffL; > - mant_bits -= 1; > + /* If we are processing the top 32 mantissa bits of a doublest > + so as to convert to a float value with implied integer bit, > + we will only be putting 31 of those 32 bits into the > + final value due to the discarding of the top bit. In the > + case of a small float value where the number of mantissa > + bits is less than 32, discarding the top bit does not alter > + the number of bits we will be adding to the result. */ > + if (mant_bits == 32) > + mant_bits -= 1; > } > > if (mant_bits < 32) Okay. Kevin