Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Elena Zannoni <ezannoni@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] dwarf2loc.c: Add missing DWARF2_REG_TO_REGNUM call
Date: Tue, 22 Apr 2003 23:48:00 -0000	[thread overview]
Message-ID: <1030422234837.ZM4467@localhost.localdomain> (raw)
In-Reply-To: Elena Zannoni <ezannoni@redhat.com> "Re: [RFA] dwarf2loc.c: Add missing DWARF2_REG_TO_REGNUM call" (Apr 22, 10:20am)

On Apr 22, 10:20am, Elena Zannoni wrote:

> OK from my side, except, could you introduce a new variable 'regnum'?

Here's what I committed:

	* dwarf2loc.c (dwarf2_evaluate_loc_desc): Invoke DWARF2_REG_TO_REGNUM
	on the DWARF2 register number prior to fetching a register.

Index: dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -p -r1.6 -r1.7
--- dwarf2loc.c	13 Apr 2003 15:53:44 -0000	1.6
+++ dwarf2loc.c	22 Apr 2003 23:18:26 -0000	1.7
@@ -223,7 +223,10 @@ dwarf2_evaluate_loc_desc (struct symbol 
   result = dwarf_expr_fetch (ctx, 0);
 
   if (ctx->in_reg)
-    retval = value_from_register (SYMBOL_TYPE (var), result, frame);
+    {
+      int regnum = DWARF2_REG_TO_REGNUM (result);
+      retval = value_from_register (SYMBOL_TYPE (var), regnum, frame);
+    }
   else
     {
       retval = allocate_value (SYMBOL_TYPE (var));


      reply	other threads:[~2003-04-22 23:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-04-21 21:47 Kevin Buettner
2003-04-21 22:02 ` Daniel Jacobowitz
2003-04-22 14:15   ` Elena Zannoni
2003-04-22 23:48     ` Kevin Buettner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1030422234837.ZM4467@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=ezannoni@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox