From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6305 invoked by alias); 19 Mar 2003 19:52:21 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6270 invoked from network); 19 Mar 2003 19:52:20 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 19 Mar 2003 19:52:20 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h2JJqKQ16486 for ; Wed, 19 Mar 2003 14:52:20 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2JJqKV26145 for ; Wed, 19 Mar 2003 14:52:20 -0500 Received: from localhost.localdomain (vpn50-21.rdu.redhat.com [172.16.50.21]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h2JJqK031976 for ; Wed, 19 Mar 2003 14:52:20 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h2JJqEY32436 for gdb-patches@sources.redhat.com; Wed, 19 Mar 2003 12:52:14 -0700 Date: Wed, 19 Mar 2003 19:52:00 -0000 From: Kevin Buettner Message-Id: <1030319195214.ZM32435@localhost.localdomain> In-Reply-To: Kevin Buettner "[RFC] mdebugread.c: Fix IRIX segfault" (Mar 18, 1:57pm) References: <1030318205742.ZM24869@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: Re: [RFC] mdebugread.c: Fix IRIX segfault MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-03/txt/msg00422.txt.bz2 I made some small changes to the patch based on some feedback from Joel. (Joel recommended that issNull be used instead of 0.) Joel also took a look at the debug info which was problematic before. As I understand it, my patch should not cause any new difficulties with that code. I've just committed the patch below. * mdebugread.c (parse_symbol): For stEnd, we're done counting when iss is issNull. Index: mdebugread.c =================================================================== RCS file: /cvs/src/src/gdb/mdebugread.c,v retrieving revision 1.43 diff -u -p -r1.43 mdebugread.c --- mdebugread.c 25 Feb 2003 21:36:18 -0000 1.43 +++ mdebugread.c 19 Mar 2003 19:44:36 -0000 @@ -916,9 +916,13 @@ parse_symbol (SYMR *sh, union aux_ext *a method whose name is identical to the class name (in particular constructor method names are different from the class name). There is therefore no risk that - this check stops the count on the StEnd of a method. */ - if (strcmp (debug_info->ss + cur_fdr->issBase + tsym.iss, - name) == 0) + this check stops the count on the StEnd of a method. + + Also, assume that we're really at the end when tsym.iss + is 0 (issNull). */ + if (tsym.iss == issNull + || strcmp (debug_info->ss + cur_fdr->issBase + tsym.iss, + name) == 0) goto end_of_fields; break;