From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18018 invoked by alias); 3 Mar 2003 18:42:27 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18002 invoked from network); 3 Mar 2003 18:42:26 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 3 Mar 2003 18:42:26 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h23IgQq15576 for ; Mon, 3 Mar 2003 13:42:26 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h23IgPV23482; Mon, 3 Mar 2003 13:42:25 -0500 Received: from localhost.localdomain (vpn50-20.rdu.redhat.com [172.16.50.20]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h23IgOC31557; Mon, 3 Mar 2003 13:42:24 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h23IgJT18307; Mon, 3 Mar 2003 11:42:19 -0700 Date: Mon, 03 Mar 2003 18:42:00 -0000 From: Kevin Buettner Message-Id: <1030303184218.ZM18306@localhost.localdomain> In-Reply-To: Andrew Cagney "[patch rfc] unwind sentinel id/pc" (Mar 2, 3:25pm) References: <3E6268AD.3080300@redhat.com> To: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: [patch rfc] unwind sentinel id/pc MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-03/txt/msg00058.txt.bz2 On Mar 2, 3:25pm, Andrew Cagney wrote: > Following on from my recent post to add an unwind_dummy_id() method, > this code adds architecture specific methods to handle the edge case of > unwinding the sentinel frame's PC/ID. > > While I'm pretty sure that the methods are needed, I'm not 100% certain > of their interfaces. The attached has: > > unwind_sentinel_id(arch, regcache, unwind_cache) > > I'm wondering if, instead it should use something like: > > unwind_sentinel_id(arch, tpid, unwind_cache) > > where a new method: > > tpid_regcache (tpid) > > could be used to obtain the tpid's register cache. I'm thinking this > since, for the case of the i386, it may need the thread's state in > addition to registers when determing the `pc'. s/tpid/ptid/ in the above. ptid_regcache() does sound useful. Kevin