From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22444 invoked by alias); 21 Feb 2003 17:29:32 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22435 invoked from network); 21 Feb 2003 17:29:32 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 21 Feb 2003 17:29:32 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h1LHTVN06508 for ; Fri, 21 Feb 2003 12:29:31 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1LHTUf00917; Fri, 21 Feb 2003 12:29:30 -0500 Received: from localhost.localdomain (vpn50-10.rdu.redhat.com [172.16.50.10]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h1LHTTt19676; Fri, 21 Feb 2003 12:29:29 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h1LHTOt15418; Fri, 21 Feb 2003 10:29:24 -0700 Date: Fri, 21 Feb 2003 17:29:00 -0000 From: Kevin Buettner Message-Id: <1030221172923.ZM15417@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: ppc_linux_init_extra_frame_info" (Feb 21, 11:59am) References: <1030221045336.ZM13013@localhost.localdomain> <3E565AFD.1080508@redhat.com> To: Andrew Cagney Subject: Re: ppc_linux_init_extra_frame_info Cc: Andreas Schwab , gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-02/txt/msg00527.txt.bz2 On Feb 21, 11:59am, Andrew Cagney wrote: > ac131313@lulu$ frep deprecated_set_frame_type > frame.c:1388:deprecated_set_frame_type (struct frame_info *frame, enum > frame_type type) > frame.h:251:extern void deprecated_set_frame_type (struct frame_info *, > i386-interix-tdep.c:166: deprecated_set_frame_type (frame, > SIGTRAMP_FRAME); > i386-interix-tdep.c:174: deprecated_set_frame_type (frame, > SIGTRAMP_FRAME); > ppc-linux-tdep.c:376: deprecated_set_frame_type (fi, SIGTRAMP_FRAME); > ppc-linux-tdep.c:380: deprecated_set_frame_type (fi, NORMAL_FRAME); > rs6000-tdep.c:181: deprecated_set_frame_type (fi, SIGTRAMP_FRAME); > > (Joel, I'm going to ignore interix :-/) > > So it's solely PPC GNU/Linux that is the cause of all the problems. An And AIX (from rs6000-tdep.c). > addition to the comment; > > /* FIXME: cagney/2002-11-18: Should be setting the frame's type > here, before anything else, and not last. Various INIT functions > are full of work-arounds for the frames type not being set > correctly from the word go. Ulgh! */ > prev->type = NORMAL_FRAME; > > is that, for legacy targets, you don't know at this point what the PC is. > > Why not also modify the nasty ppc-linux hack to read: > > if (get_frame_type () == NORMAL) > if (pc in sigtramp) > deprecated set frame type () That's okay with me. Kevin