From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24920 invoked by alias); 3 Feb 2003 20:46:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24909 invoked from network); 3 Feb 2003 20:46:10 -0000 Received: from unknown (HELO mx1.redhat.com) (172.16.49.200) by 172.16.49.205 with SMTP; 3 Feb 2003 20:46:10 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id h13KkAf17183 for ; Mon, 3 Feb 2003 15:46:10 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h13KkAa15951; Mon, 3 Feb 2003 15:46:10 -0500 Received: from localhost.localdomain (vpn50-31.rdu.redhat.com [172.16.50.31]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id h13KkAj29717; Mon, 3 Feb 2003 15:46:10 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id h13Kk4J26721; Mon, 3 Feb 2003 13:46:04 -0700 Date: Mon, 03 Feb 2003 20:46:00 -0000 From: Kevin Buettner Message-Id: <1030203204604.ZM26720@localhost.localdomain> In-Reply-To: Kevin Buettner "[RFC] s390-tdep.c: Define address class functions for s390x" (Jan 27, 4:26pm) References: <1030127232625.ZM2026@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: Re: [RFC] s390-tdep.c: Define address class functions for s390x MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-02/txt/msg00089.txt.bz2 On Jan 27, 4:26pm, Kevin Buettner wrote: > The default pointer size for s390x is 64 bits. The patch below causes > 32-bit pointer types obtained from (dwarf2) debug info to be stored as > a separate type and to be qualified (in gdb's ptype output) as > "@mode32". [Patches to gdbtypes.[hc] and dwarf2read.c which implement > address class support have already been committed. They need to be > revisited, however, because in the course of testing out this patch, I > found a bug. More on that later...] > > Comments? > > * s390-tdep.c (s390_address_class_type_flags) > (s390_address_class_type_flags_to_name) > (s390_address_class_name_to_type_flags): New functions. > (s390_gdbarch_init): Define ADDRESS_CLASS_TYPE_FLAGS_TO_NAME, > ADDRESS_CLASS_NAME_TO_TYPE_FLAGS, and ADDRESS_CLASS_TYPE_FLAGS. Committed. With regard to the bug noted above, I've posted a patch which fixes it: http://sources.redhat.com/ml/gdb-patches/2003-01/msg00790.html Kevin