Re: [RFA] mips-tdep.c: Fix inferior function call breakage

Daniel Jacobowitz
2003-01-23T22:42:31Z

On Thu, Jan 23, 2003 at 04:00:32PM -0500, Andrew Cagney wrote:
> >Without the following patch in place, I've found that inferior function
> >calls are badly broken for the mips linux targets that I've been testing.
> >(The warning in heuristic_proc_start() is tripped and things degrade
> >quickly
> >from there...)
> >
> >Okay?
> >
> > * mips-tdep.c (find_proc_desc): Return early if in a dummy frame.
>
> Hmm, explicit tests for PC in call-dummy set of alarm bells.
>
> Kevin, can you post a backtrace showing how the program came to be
> there? Two alternative possabilities (in addition to this patch) are:
>
> - the code should not have been called (and the dummy-frame flow should
> have gone elsewhere)
>
> - the code needs to be made per-frame

How is via INIT_EXTRA_FRAME_INFO, already a legacy mechanism.
Presumably someone could convert MIPS; although if no one's going to do
that, we might want Kevin's change in the interim.

--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer