From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10690 invoked by alias); 16 Dec 2006 11:18:38 -0000 Received: (qmail 10682 invoked by uid 22791); 16 Dec 2006 11:18:37 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-vbr3.xs4all.nl (HELO smtp-vbr3.xs4all.nl) (194.109.24.23) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 16 Dec 2006 11:18:28 +0000 Received: from webmail.xs4all.nl (dovemail5.xs4all.nl [194.109.26.7]) by smtp-vbr3.xs4all.nl (8.13.8/8.13.8) with ESMTP id kBGBIIBm002917; Sat, 16 Dec 2006 12:18:19 +0100 (CET) (envelope-from mark.kettenis@xs4all.nl) Received: from 82.92.89.47 (SquirrelMail authenticated user sibelius) by webmail.xs4all.nl with HTTP; Sat, 16 Dec 2006 12:18:23 +0100 (CET) Message-ID: <10247.82.92.89.47.1166267903.squirrel@webmail.xs4all.nl> In-Reply-To: <200612160846.31929.skrll@netbsd.org> References: <200611301323.18743.skrll@netbsd.org> <200612151623.30618.skrll@netbsd.org> <20061215163730.GA9822@nevyn.them.org> <200612160846.31929.skrll@netbsd.org> Date: Sat, 16 Dec 2006 11:18:00 -0000 Subject: Re: PATCH: Provde a pid to filename conversion for NetBSD From: "Mark Kettenis" To: "Nick Hudson" Cc: "Daniel Jacobowitz" , gdb-patches@sources.redhat.com User-Agent: SquirrelMail/1.4.8 MIME-Version: 1.0 Content-Type: text/plain;charset=iso-8859-1 Content-Transfer-Encoding: 8bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-12/txt/msg00207.txt.bz2 > On Friday 15 December 2006 16:37, Daniel Jacobowitz wrote: > > On Fri, Dec 15, 2006 at 04:23:30PM +0000, Nick Hudson wrote: > > > > 2006-11-30 Nick Hudson > > > > > > > > * i386nbsd-nat.c: Include "nbsd-nat.h". > > > > (_initialize_i386nbsd_nat): Update target vector to use > > > > nbsd_pid_to_exec_file. > > > > > > > > * config/i386/nbsdelf.mh (NATDEPFILES): Add nbsd-nat.o > > > > > > > > * nbsd-nat.c: New file. > > > > * nbsd-nat.h: New file. > > > > * Makefile.in (ALLDEPFILES): Add nbsd-nat.c. > > > > (nbsd_nat_h): New variable. > > > > (nbsd-nat.o): New dependency. > > > > > > What needs to happen for this to go in? > > > > Someone needs to review it. I was hoping that someone who actually > > used NetBSD would speak up :-) If no one does, I'll do it myself. > > I sent Jason Thorpe (current NetBSD maintainer) an email, but got not > response. :( Reasoning that NetBSD and OpenBSD are similar enough, I suppose I can do it. You're origional diff broke OpenBSD/i386 support, since it re-used the NetBSD/i386 native code, but I've solved that by moving some code from i386nbsd-nat.c to i386obsd-nat.c. If I ever get to implement this for OpenBSD it will not use /proc, and I had some other reasons to make the seperation anyway. Anyway, your diff looks pretty good, except for some minor nits: * Always include "defs.h" first. * The FSF lawyers have apparently changed their mind again, and we should use Copyright (C) again. * Make sure the dependencies in Makefile.in are up to date; you forgot to add a dependency rule for nbsd-nat.o. I'll fix those when I commit the diff. However, before I can do that, I need to be sure you've got an FSF copyright assignment for GDB in place. Or Daniel, do you think there is not enough origional code here to warrant one? > > It looks generally fine. Is this going to work for every NetBSD > > platform? Should it be added to all of them, rather than just i386? > > Looks like GDB supports 11. > > I have diffs to add support to all other NetBSD platforms which I > committed to > the NetBSD tree recently. I'll send those after this one goes in. Ah, that'd be good. Perhaps that means that a few more NetBSD/OpenBSD seperation diffs are needed, but that's not a big problem. > Thanks, > Nick