From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 431E8383E80D for ; Tue, 26 May 2020 17:50:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 431E8383E80D Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-297-hGxH6xOmMrOseOC5H-or4g-1; Tue, 26 May 2020 13:50:11 -0400 X-MC-Unique: hGxH6xOmMrOseOC5H-or4g-1 Received: by mail-wr1-f69.google.com with SMTP id c14so296924wrw.11 for ; Tue, 26 May 2020 10:50:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gpgxszRSP7Sujgfhv6i0NCOgcKWk8HnTi+eH8o/QERw=; b=nBJVxpqOQiE0dkqsNYK29qpc7ephQA2IxKNDjJCnEPiHvTa6Aaulet+4t1za8fV9RL 56wNa+7vna6XeY3VPEixWBBMYTpJrxLJZZzqnortON8PXDIIh7q6a7GsS0GfzT0sBCJF qruwDST5QKZgSF+BU3CfBZQLOvPYB1iWUNVSncdb/utZSGjVCvBv5TSbnvLLOishDnzU W80cv/DzmZmIpYIA3WEaNXnvZONyHETlhJ+63vjXTbB+rZKw9pzZc51gQjl9QErd4YcD PrNO9PMSiLz+1c4/kXdBv+DKtEU7g/Pk60nvJddnpDSqvrTtLMVoLn7LTaeSFdAlRVzp EFEg== X-Gm-Message-State: AOAM533gW7RCJvKTHStf7gai+ycdh/jpzgs+XaoB+yhhSci1ht663UFE 1JYew0sngRxAsV/tKQi/5zsMlEut+VgfPKzzXWy5go7Vr2pqKovqNfiMiZqda/dUMIB95oXGPWc ugfoCiWFeGYn4nTIt9zPKsw== X-Received: by 2002:a5d:5605:: with SMTP id l5mr10063089wrv.318.1590515409883; Tue, 26 May 2020 10:50:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySQ/+kl8zTN+/HQisiHaJyf8Y8cySliaX7C2FeF9uPexksy2vZL/9SEC57wc8qaqYmhhLx3Q== X-Received: by 2002:a5d:5605:: with SMTP id l5mr10063075wrv.318.1590515409673; Tue, 26 May 2020 10:50:09 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id n1sm532120wrp.10.2020.05.26.10.50.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 10:50:09 -0700 (PDT) Subject: Re: [PATCH,v2 testsuite] Fix some duplicate test names To: Luis Machado , gdb-patches@sourceware.org References: <20200526141848.22771-1-luis.machado@linaro.org> <20200526173925.30491-1-luis.machado@linaro.org> From: Pedro Alves Message-ID: <1021975e-b67f-5e04-4469-2640c27add81@redhat.com> Date: Tue, 26 May 2020 18:50:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200526173925.30491-1-luis.machado@linaro.org> Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 May 2020 17:50:14 -0000 Hi, spotted a couple more issues: On 5/26/20 6:39 PM, Luis Machado wrote: > gdb_test_multiple "$test" "$test" { > -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" { > set bp $expect_out(1,string) > - pass "$test" > + pass "$test inserted as number $bp" Same issue with FAIL vs PASS messages. This needs to be: - gdb_test_multiple "$test" "$test" { + gdb_test_multiple "$test" "$test inserted as number $bp" { -re "Breakpoint (\[0-9\]*) at .*$where.*$gdb_prompt $" { set bp $expect_out(1,string) - pass "$test" + pass $gdb_test_name > - gdb_test_multiple "break *test_str_pc" "break test_str_pc" { > + gdb_test_multiple "break *test_str_pc" "" { > -re "Breakpoint.*at.* file .*$srcfile, line.*\r\n$gdb_prompt $" { > - pass "break test_str_pc" > + pass $gdb_test_name > } > -re "No symbol.*\r\n$gdb_prompt $" { > pass "break test_str_pc" Please update the other "-re" cases too, so they all have the same message. Here the pass call in the last line shown has a different message. Thanks, Pedro Alves