Re: [RFC] Replace complain() with complaint()

Andrew Cagney
2002-12-13T21:49:52Z

> Okay, now I see a -Wformat warning. Fortunately, buildsym.c was the only
> file affected. Below are the diffs that I propose using for that file.
> (These take the place of the buildsym.c diffs that I previously posted.)
> The ChangeLog entries remain the same.

Ok. Out of interest, how many other problems did the first pass find?

> Note the use of paddr_nz() to convert the CORE_ADDR to a string. According
> to defs.h, this most closely corresponds to the %lx format. Also, the
> paddr() family of functions have an advantage over local_hex_string_custom()
> (and the like) in that it's safe to use several of these calls together
> without having to worry about the internal storage being overwritten.

Hmm, bug report!

Things to do includes the addition of a local_address_string_custom()
method that does in a language dependant way the display of an address.
This problem with buffers should be fixed then.

Andrew