From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13929 invoked by alias); 11 Dec 2002 20:56:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13917 invoked from network); 11 Dec 2002 20:56:42 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 11 Dec 2002 20:56:42 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gBBKV2P13701 for ; Wed, 11 Dec 2002 15:31:02 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBBKufD13900 for ; Wed, 11 Dec 2002 15:56:41 -0500 Received: from localhost.localdomain (vpn50-3.rdu.redhat.com [172.16.50.3]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBBKufY27452 for ; Wed, 11 Dec 2002 15:56:41 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id gBBKuZa19743 for gdb-patches@sources.redhat.com; Wed, 11 Dec 2002 13:56:35 -0700 Date: Wed, 11 Dec 2002 13:02:00 -0000 From: Kevin Buettner Message-Id: <1021211205635.ZM19742@localhost.localdomain> In-Reply-To: Kevin Buettner "[RFA] dwarf2read.c: complain() -> complaint()" (Dec 9, 4:39pm) References: <1021209233902.ZM5908@localhost.localdomain> To: gdb-patches@sources.redhat.com Subject: Re: [RFA] dwarf2read.c: complain() -> complaint() MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-12/txt/msg00367.txt.bz2 On Dec 9, 4:39pm, Kevin Buettner wrote: > * dwarf2read.c (dwarf2_const_ignored, dwarf2_volatile_ignored) > (dwarf2_non_const_array_bound_ignored) > (dwarf2_missing_line_number_section) > (dwarf2_statement_list_fits_in_line_number_section) > (dwarf2_mangled_line_number_section, dwarf2_unsupported_die_ref_attr) > (dwarf2_unsupported_stack_op, dwarf2_complex_location_expr) > (dwarf2_unsupported_tag, dwarf2_unsupported_at_encoding) > (dwarf2_unsupported_at_frame_base, dwarf2_unexpected_tag) > (dwarf2_missing_at_frame_base, dwarf2_bad_static_member_name) > (dwarf2_unsupported_accessibility, dwarf2_bad_member_name_complaint) > (dwarf2_missing_member_fn_type_complaint) > (dwarf2_vtbl_not_found_complaint, dwarf2_absolute_sibling_complaint) > (dwarf2_const_value_length_mismatch) > (dwarf2_unsupported_const_value_attr, dwarf2_misplaced_line_number) > (dwarf2_line_header_too_long, dwarf2_missing_macinfo_section) > (dwarf2_macros_too_long, dwarf2_macros_not_terminated) > (dwarf2_macro_outside_file, dwarf2_macro_unmatched_end_file) > (dwarf2_macro_malformed_definition, dwarf2_macro_spaces_in_definition) > (dwarf2_invalid_attrib_class, dwarf2_invalid_pointer_size): Delete > complaints using deprecated struct.. > (dwarf2_non_const_array_bound_ignored_complaint) > (dwarf2_complex_location_expr_complaint) > (dwarf2_unsupported_at_frame_base_complaint) > (dwarf2_const_value_length_mismatch_complaint) > (dwarf2_macros_too_long_complaint) > (dwarf2_macro_malformed_definition_complaint) > (dwarf2_invalid_attrib_class_complaint): New functions. > (read_func_scope, dwarf2_attach_fields_to_type, dwarf2_add_member_fn) > (read_structure_scope, read_array_type, read_common_block) > (read_tag_pointer_type, read_base_type, read_partial_die) > (dwarf_decode_line_header, check_cu_functions, dwarf_decode_lines) > (new_symbol, dwarf2_const_value, read_type_die) > (dwarf2_get_ref_die_offset, decode_locdesc, consume_improper_spaces) > (parse_macro_definition, dwarf_decode_macros): Replace calls to > complain() with, possibly indirect, calls to complaint(). Committed. Since this approach seems to be acceptable, I'll generate patches for the other files which still use complain() and post them for comment. Kevin