From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13328 invoked by alias); 10 Dec 2002 16:32:31 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13321 invoked from network); 10 Dec 2002 16:32:31 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 10 Dec 2002 16:32:31 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id gBAG6wP10707 for ; Tue, 10 Dec 2002 11:06:58 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBAGWTD17641; Tue, 10 Dec 2002 11:32:29 -0500 Received: from localhost.localdomain (vpn50-3.rdu.redhat.com [172.16.50.3]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id gBAGWSq05280; Tue, 10 Dec 2002 11:32:28 -0500 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id gBAGWNm23043; Tue, 10 Dec 2002 09:32:23 -0700 Date: Tue, 10 Dec 2002 09:03:00 -0000 From: Kevin Buettner Message-Id: <1021210163223.ZM23042@localhost.localdomain> In-Reply-To: Andrew Cagney "Re: [RFA] dwarf2read.c: complain() -> complaint()" (Dec 10, 11:13am) References: <1021209233902.ZM5908@localhost.localdomain> <3DF6129C.9000700@redhat.com> To: Andrew Cagney Subject: Re: [RFA] dwarf2read.c: complain() -> complaint() Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-12/txt/msg00325.txt.bz2 On Dec 10, 11:13am, Andrew Cagney wrote: > Definitly fine with the theory. Two reservations (really just one). > > - how is the result with -Wformat? The reason behind switching from > complain() to complaint was to get the parameters checked and hence find > some nasty address printing bugs. No warnings. (I was looking for this too when I eyeballed the resulting patch.) > - I suspect it will need a visual audit to check for any cases of: > "%08lx", (long) core_addr_variable Yes, I agree. At the moment my script is only smart enough to handle the cases that occur in dwarf2read.c. An excerpt: # yes, this is naive, but it's all we need for dwarf2read.c... $formals .= 'const char *' if $1 eq 's'; $formals .= 'long' if $1 eq 'l'; $formals .= 'int' if $1 eq 'd'; $formals .= 'int' if $1 eq 'x'; I'll augment the script as I go... In some cases, hand edits may be necessary. Kevin