From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11070 invoked by alias); 17 Oct 2002 18:15:11 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11016 invoked from network); 17 Oct 2002 18:15:02 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 17 Oct 2002 18:15:02 -0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g9HHsCw31706 for ; Thu, 17 Oct 2002 13:54:12 -0400 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [172.16.52.156]) by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9HIF0f29213; Thu, 17 Oct 2002 14:15:00 -0400 Received: from localhost.localdomain (vpn50-3.rdu.redhat.com [172.16.50.3]) by pobox.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g9HIExT00917; Thu, 17 Oct 2002 14:14:59 -0400 Received: (from kev@localhost) by localhost.localdomain (8.11.6/8.11.6) id g9HIErD32337; Thu, 17 Oct 2002 11:14:53 -0700 Date: Thu, 17 Oct 2002 11:15:00 -0000 From: Kevin Buettner Message-Id: <1021017181453.ZM32336@localhost.localdomain> In-Reply-To: Eli Zaretskii "Re: [PATCH RFA/RFC] Address class support" (Oct 17, 8:39am) References: To: Eli Zaretskii Subject: Re: [PATCH RFA/RFC] Address class support Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-10/txt/msg00287.txt.bz2 On Oct 17, 8:39am, Eli Zaretskii wrote: > Approved, with the following comments/suggestions: > > > +@deftypefn {Target Macro} int ADDRESS_CLASS_TYPE_FLAGS (int @var{byte_size}, int @var{dwarf2_addr_class}) > > Do you really need to use @var inside deftypefn (I don't have the Texinfo > manual handy, sorry)? I thought the @def... directives supply the @var > automatically. According to the texinfo manual, an explicit @var is needed For deftypefn: The argument names that you write in @deftypefn are not subject to an implicit @var--since the actual names of the arguments in @deftypefn are typically scattered among data type names and keywords, Texinfo cannot find them without help. Instead, you must write @var explicitly around the argument names. In the example above, the argument names are foo and bar. (I didn't know this ahead of time though; I was just following the example set by the rest of the manual.) > > +Consider a hypothetical architecture in which addresses are normally > > +32-bits wide, but 16-bit addresses are also supported. Furthermore, > > +suppose that the DWARF 2 information for this architecture simply > > I suggest to use either DWARF2 or @w{DWARF 2}, to prevent TeX and makeinfo > from splitting this between DWARF and 2. I'll use @w{DWARF 2} for consistency with the rest of the manual. (There are some other places that need to be fixed though.) > > +@smallexample > > +somearch_address_class_type_flags (int byte_size, int dwarf2_addr_class) > > This line is too long (even for @smallexample), so please break it in > two: > > +somearch_address_class_type_flags (int byte_size, > + int dwarf2_addr_class) > > (There are more too long lines in your examples. In general, any line > inside @smallexample that is longer than 64 characters should be broken > into several lines, or else it will cause overfull hbox'es when you TeX > the manual.) Okay, fixed. Thanks for your help. Kevin